You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/25 07:05:13 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request #195: Drop support for Flask due to Jinja2 issue
Superskyyy opened a new pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195
Flask 1.x is EOL and Jinja2 dependency now breaks UT, there's no need for us to maintain this version anymore.
Please merge this first.
Signed-off-by: Superskyyy <su...@outlook.com><!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #195: Drop support for Flask 1.x due to EOL & Jinja2 issue
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195#issuecomment-1078727435
When was its EOL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #195: Drop support for Flask 1.x due to EOL & Jinja2 issue
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195#issuecomment-1078737226
> When was its EOL?
According to Flask core team's reply, they only support the latest version which is almost 2.1.x. The last 1.x version was released in early 2021 and most users have upgraded to 2.x.
The main reason is we have to pin dependencies of Flask individually, which is hard to manage with requirements.txt here, anyway that's another story, I should upgrade the project dependency tool to poetry/pdm in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng merged pull request #195: Drop support for Flask 1.x due to EOL & Jinja2 issue
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy edited a comment on pull request #195: Drop support for Flask 1.x due to EOL & Jinja2 issue
Posted by GitBox <gi...@apache.org>.
Superskyyy edited a comment on pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195#issuecomment-1078740813
> Then you need to remove plugins.md accordingly. I am not sure who python agent generates changelog or manually, but we need to highlight we dropped versions.
My bad I forgot to regenerate the docs here. I have another PR to update all missing CHANGELOGs next door.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #195: Drop support for Flask 1.x due to EOL & Jinja2 issue
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195#issuecomment-1078740813
> Then you need to remove plugins.md accordingly. I am not sure who python agent generates changelog or manually, but we need to highlight we dropped versions.
My bad I forgot to regenerate the docs here. I have another PR to update all missing CHANGELOGs coming soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #195: Drop support for Flask 1.x due to EOL & Jinja2 issue
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #195:
URL: https://github.com/apache/skywalking-python/pull/195#issuecomment-1078738930
Then you need to remove plugins.md accordingly. I am not sure who python agent generates changelog or manually, but we need to highlight we dropped versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org