You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Tom Götz <to...@decoded.de> on 2016/09/05 10:12:03 UTC
Wicketstuff commit (push) access
Hi there,
I’d like to do some improvements to wicketstuff-select2 and therefore am requesting push access.
My github username is: tgoetz
Thanks in advance,
Tom
Re: Wicketstuff commit (push) access
Posted by Maxim Solodovnik <so...@gmail.com>.
I'll to perform quick review/merge :)
Thanks in advance for contributions :)
WBR, Maxim
(from mobile, sorry for the typos)
On Sep 5, 2016 17:32, "Ernesto Reinaldo Barreiro" <re...@gmail.com>
wrote:
> IMHO it is the best approach as all contributions will be reviewed before
> they make it into the code base.
>
> On Mon, Sep 5, 2016 at 12:30 PM, Tom Götz <to...@decoded.de> wrote:
>
> > I can also stick to that workflow, that’s perfectly OK for me!
> >
> > Cheers,
> > Tom
> >
> >
> > > On 05.09.2016, at 12:24, Ernesto Reinaldo Barreiro <reiern70@gmail.com
> >
> > wrote:
> > >
> > > I normally just
> > >
> > > 1- fork
> > > 2- Create PR
> > > 3-Other member validate and agree and Martin Grigorov or other wicket
> > > committer merge changes when approved.
> >
> >
> >
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>
Re: Wicketstuff commit (push) access
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
IMHO it is the best approach as all contributions will be reviewed before
they make it into the code base.
On Mon, Sep 5, 2016 at 12:30 PM, Tom Götz <to...@decoded.de> wrote:
> I can also stick to that workflow, that’s perfectly OK for me!
>
> Cheers,
> Tom
>
>
> > On 05.09.2016, at 12:24, Ernesto Reinaldo Barreiro <re...@gmail.com>
> wrote:
> >
> > I normally just
> >
> > 1- fork
> > 2- Create PR
> > 3-Other member validate and agree and Martin Grigorov or other wicket
> > committer merge changes when approved.
>
>
>
--
Regards - Ernesto Reinaldo Barreiro
Re: Wicketstuff commit (push) access
Posted by Tom Götz <to...@decoded.de>.
I can also stick to that workflow, that’s perfectly OK for me!
Cheers,
Tom
> On 05.09.2016, at 12:24, Ernesto Reinaldo Barreiro <re...@gmail.com> wrote:
>
> I normally just
>
> 1- fork
> 2- Create PR
> 3-Other member validate and agree and Martin Grigorov or other wicket
> committer merge changes when approved.
Re: Wicketstuff commit (push) access
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
I normally just
1- fork
2- Create PR
3-Other member validate and agree and Martin Grigorov or other wicket
committer merge changes when approved.
On Mon, Sep 5, 2016 at 12:12 PM, Tom Götz <to...@decoded.de> wrote:
> Hi there,
>
> I’d like to do some improvements to wicketstuff-select2 and therefore am
> requesting push access.
> My github username is: tgoetz
>
> Thanks in advance,
> Tom
>
>
>
>
--
Regards - Ernesto Reinaldo Barreiro