You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Technoboy- (via GitHub)" <gi...@apache.org> on 2023/12/11 14:32:12 UTC
[PR] [fix][test] Fix flaky test ReplicatorGlobalNSTest#testRemoveLocalClusterOnGlobalNamespace [pulsar]
Technoboy- opened a new pull request, #21708:
URL: https://github.com/apache/pulsar/pull/21708
Fixes #21534
### Motivation
The root cause is that `retryStrategically` only tries to test 50 times, not caring about the result. So the result can be false after 50 times. Then the broker deletes the topic and `pulsar1.getBrokerService().getTopics().containsKey(topicName)=false`.
But the `close` command from broker to producer is async, so the `producer1(line-97)` can be connected at that time.
```
MockedPulsarServiceBaseTest.retryStrategically((test) -> !pulsar1.getBrokerService().getTopics().containsKey(topicName), 50, 150);
```
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix flaky test ReplicatorGlobalNSTest#testRemoveLocalClusterOnGlobalNamespace [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #21708:
URL: https://github.com/apache/pulsar/pull/21708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix flaky test ReplicatorGlobalNSTest#testRemoveLocalClusterOnGlobalNamespace [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21708:
URL: https://github.com/apache/pulsar/pull/21708#issuecomment-1851539879
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21708](https://app.codecov.io/gh/apache/pulsar/pull/21708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (30928df) into [master](https://app.codecov.io/gh/apache/pulsar/commit/495b141c7bebc0356297546e9db88c9e087f5039?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (495b141) will **increase** coverage by `36.62%`.
> Report is 2 commits behind head on master.
> The diff coverage is `n/a`.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/21708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21708 +/- ##
=============================================
+ Coverage 36.75% 73.37% +36.62%
- Complexity 12271 32654 +20383
=============================================
Files 1717 1893 +176
Lines 131197 140714 +9517
Branches 14339 15502 +1163
=============================================
+ Hits 48220 103249 +55029
+ Misses 76596 29354 -47242
- Partials 6381 8111 +1730
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21708/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.15% <ø> (+0.03%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.72% <ø> (-0.06%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.66% <ø> (+40.79%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1464 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21708/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org