You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2023/05/08 15:51:13 UTC
[GitHub] [daffodil] stevedlawrence opened a new pull request, #1013: Remove use of the IntegrationTest sbt configuration
stevedlawrence opened a new pull request, #1013:
URL: https://github.com/apache/daffodil/pull/1013
Upcoming versions of sbt will deprecate the IntegrationTest configuration. Using their suggested migration path, this moves the existing integration tests to a new daffodil-test-integration project. Because of the extra time needed to stage the CLi and run the tests, this project is not aggregeated so must be run manually.
DAFFODIL-2811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #1013: Remove use of the IntegrationTest sbt configuration
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #1013:
URL: https://github.com/apache/daffodil/pull/1013#discussion_r1187720010
##########
.github/workflows/main.yml:
##########
@@ -161,7 +161,7 @@ jobs:
run: $SBT test
- name: Run Integration Tests
- run: $SBT IntegrationTest/test
+ run: $SBT daffodil-test-integration/Test/test
Review Comment:
Good call, the `Test` isn't needed, will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #1013: Remove use of the IntegrationTest sbt configuration
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #1013:
URL: https://github.com/apache/daffodil/pull/1013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #1013: Remove use of the IntegrationTest sbt configuration
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #1013:
URL: https://github.com/apache/daffodil/pull/1013#issuecomment-1538795263
> I wonder if this change could help us merge https://github.com/apache/daffodil/pull/986
Possibly. It looks like 42 tests failed in the jline PR, so we'd probably need to move all of those here. Doable, but would probably cause CI to take much longer.
The debugger isn't a really a critical part of the CLI, and I don't know of any updates to jline that we really need. Maybe we just avoid upgrading jline until sbt fixes this issue? Unfortunately that might be a while, likely not until 2.0 at the earliest, but I don't think we're in any rush to update jline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on a diff in pull request #1013: Remove use of the IntegrationTest sbt configuration
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #1013:
URL: https://github.com/apache/daffodil/pull/1013#discussion_r1187702895
##########
.github/workflows/main.yml:
##########
@@ -161,7 +161,7 @@ jobs:
run: $SBT test
- name: Run Integration Tests
- run: $SBT IntegrationTest/test
+ run: $SBT daffodil-test-integration/Test/test
Review Comment:
According to the DEVELOP.md changes below, `daffodil-test-integration/test` would work too. Why do you use the longer `daffodil-test-integration/Test/test` in the CI workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org