[GitHub] [hive] ramesh0201 commented on a change in pull request #2099: HIVE-24761: Support vectorization for bounded windows in PTF

[GitBox <gi...@apache.org>]

ramesh0201 commented on a change in pull request #2099:
URL: https://github.com/apache/hive/pull/2099#discussion_r634911824



##########
File path: ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt
##########
@@ -34,20 +34,17 @@ public class <ClassName> extends VectorExpression {
 
   private static final long serialVersionUID = 1L;
 
-  private final int colNum1;
   private final int colNum2;

Review comment:
       @abstractdog Option a also looks good to me. If you think that will be better then we can go with that. 
   
   Otherwise if we choose option b we can choose 2) new int[] { arg1Column, arg3Column, -1}; This way it is always easy to know only first n columns are used, rather than confused with the interleaving part




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org