You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "phongn (via GitHub)" <gi...@apache.org> on 2023/11/15 00:12:33 UTC
[PR] Remove HAVE_STDLIB_H build var [trafficserver]
phongn opened a new pull request, #10785:
URL: https://github.com/apache/trafficserver/pull/10785
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn commented on code in PR #10785:
URL: https://github.com/apache/trafficserver/pull/10785#discussion_r1396442034
##########
include/tscore/ink_platform.h:
##########
@@ -60,7 +60,7 @@
struct ifafilt;
#include <net/if.h>
-#ifdef HAVE_STDLIB_H
+#if __has_include(<stdlib.h>)
Review Comment:
I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10785:
URL: https://github.com/apache/trafficserver/pull/10785#issuecomment-1811651108
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10785:
URL: https://github.com/apache/trafficserver/pull/10785#issuecomment-1811598052
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn closed pull request #10785: Remove HAVE_STDLIB_H build var
URL: https://github.com/apache/trafficserver/pull/10785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #10785:
URL: https://github.com/apache/trafficserver/pull/10785#discussion_r1396444512
##########
include/tscore/ink_platform.h:
##########
@@ -60,7 +60,7 @@
struct ifafilt;
#include <net/if.h>
-#ifdef HAVE_STDLIB_H
+#if __has_include(<stdlib.h>)
Review Comment:
Yeah, I agree with @dragon512 on this one . I can't think of any system that doesn't need stdlib.h. But at the same time, this is to remove an unnecessary check in CMakeLists.txt. If there is any doubt I'm ok with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "dragon512 (via GitHub)" <gi...@apache.org>.
dragon512 commented on code in PR #10785:
URL: https://github.com/apache/trafficserver/pull/10785#discussion_r1396406126
##########
include/tscore/ink_platform.h:
##########
@@ -60,7 +60,7 @@
struct ifafilt;
#include <net/if.h>
-#ifdef HAVE_STDLIB_H
+#if __has_include(<stdlib.h>)
Review Comment:
When would we ever not have stdlib.h ... it is a standard C header
We should remove the check for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_STDLIB_H build var [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #10785:
URL: https://github.com/apache/trafficserver/pull/10785#discussion_r1393543997
##########
include/tscore/ink_platform.h:
##########
@@ -60,7 +60,7 @@
struct ifafilt;
#include <net/if.h>
-#ifdef HAVE_STDLIB_H
+#ifdef __has_include(<stdlib.h>)
Review Comment:
```suggestion
#if __has_include(<stdlib.h>)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org