You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "stefanvodita (via GitHub)" <gi...@apache.org> on 2025/05/03 15:52:05 UTC
[PR] Fix changelog verifier [lucene]
stefanvodita opened a new pull request, #14606:
URL: https://github.com/apache/lucene/pull/14606
I managed to find and fix a few issues:
1. Some GitHub-provided variables seemed not to expand correctly (see lines 29,30 in the new version).
2. We need to fetch deep to ensure the commits we diff are present.
3. The diff should happen between the PR head and the merge base, not the main head. Otherwise the diff for a PR that is not rebased will contain unrelated changes.
Addresses #13898 #14190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix changelog verifier [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita merged PR #14606:
URL: https://github.com/apache/lucene/pull/14606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org