You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Cheng Lian (JIRA)" <ji...@apache.org> on 2016/07/14 16:53:20 UTC

[jira] [Resolved] (SPARK-16529) SQLTestUtils.withTempDatabase should set `default` database before dropping

     [ https://issues.apache.org/jira/browse/SPARK-16529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cheng Lian resolved SPARK-16529.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request 14184
[https://github.com/apache/spark/pull/14184]

> SQLTestUtils.withTempDatabase should set `default` database before dropping
> ---------------------------------------------------------------------------
>
>                 Key: SPARK-16529
>                 URL: https://issues.apache.org/jira/browse/SPARK-16529
>             Project: Spark
>          Issue Type: Test
>          Components: Tests
>            Reporter: Dongjoon Hyun
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> `withTempDatabase` is a frequently used test harness to setup a temporary table and clean up finally. This issue improves like the following for usability.
> {code}
> -    try f(dbName) finally spark.sql(s"DROP DATABASE $dbName CASCADE")
> +    try f(dbName) finally {
> +      if (spark.catalog.currentDatabase == dbName) {
> +        spark.sql(s"USE ${DEFAULT_DATABASE}")
> +      }
> +      spark.sql(s"DROP DATABASE $dbName CASCADE")
> +    }
> {code}
> In case of forgetting to reset the databaes, `withTempDatabase` will not raise Exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org