You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/31 13:24:59 UTC

[GitHub] [flink] zentol opened a new pull request #10984: [FLINK-15835][build][oss] Exclude hadoop-common

zentol opened a new pull request #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984
 
 
   Adds an explicit exclusion for `hadoop-common` to `hadoop-aliyun`, since a trimmed-down version of this dependency is already supplied by `flink-fs-hadoop-shaded`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984#issuecomment-580743008
 
 
   <!--
   Meta data
   Hash:9a18aad4dd1220eb647af4991e4de9281fcd04a0 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146927909 TriggerType:PUSH TriggerID:9a18aad4dd1220eb647af4991e4de9281fcd04a0
   Hash:9a18aad4dd1220eb647af4991e4de9281fcd04a0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4732 TriggerType:PUSH TriggerID:9a18aad4dd1220eb647af4991e4de9281fcd04a0
   -->
   ## CI report:
   
   * 9a18aad4dd1220eb647af4991e4de9281fcd04a0 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146927909) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4732) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #10984: [FLINK-15835][build][oss] Exclude hadoop-common

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wangyang0918 commented on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984#issuecomment-586983040
 
 
   @zentol Thanks for your changes about the oss filesystem. This is really a good fix. I have tested it could decrease the size of jar from 36M to 16M. Recently we want to use the oss filesystem as plugin, unfortunately even we apply this patch it still could not work because of this ticket[1].
   
   [1]. https://issues.apache.org/jira/browse/FLINK-16115

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984#issuecomment-580732567
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9a18aad4dd1220eb647af4991e4de9281fcd04a0 (Fri Jan 31 13:27:03 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984#issuecomment-580743008
 
 
   <!--
   Meta data
   Hash:9a18aad4dd1220eb647af4991e4de9281fcd04a0 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146927909 TriggerType:PUSH TriggerID:9a18aad4dd1220eb647af4991e4de9281fcd04a0
   Hash:9a18aad4dd1220eb647af4991e4de9281fcd04a0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4732 TriggerType:PUSH TriggerID:9a18aad4dd1220eb647af4991e4de9281fcd04a0
   -->
   ## CI report:
   
   * 9a18aad4dd1220eb647af4991e4de9281fcd04a0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146927909) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4732) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10984: [FLINK-15835][build][oss] Exclude hadoop-common
URL: https://github.com/apache/flink/pull/10984#issuecomment-580743008
 
 
   <!--
   Meta data
   Hash:9a18aad4dd1220eb647af4991e4de9281fcd04a0 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9a18aad4dd1220eb647af4991e4de9281fcd04a0
   -->
   ## CI report:
   
   * 9a18aad4dd1220eb647af4991e4de9281fcd04a0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services