You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/27 19:35:42 UTC
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4645: Api v3
rob05c commented on a change in pull request #4645:
URL: https://github.com/apache/trafficcontrol/pull/4645#discussion_r416093217
##########
File path: traffic_ops/ort/atstccfg/toreq/toreq.go
##########
@@ -37,7 +37,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/lib/go-util"
- toclient "github.com/apache/trafficcontrol/traffic_ops/client"
+ toclient "github.com/apache/trafficcontrol/traffic_ops/v2-client"
Review comment:
Yeah, this is vendored. It's not necessary to change this, unless API 1 is being removed from Traffic Ops. If so, the `vendor/` dir needs updating along with this import.
The latest client is in https://github.com/apache/trafficcontrol/blob/master/traffic_ops/ort/atstccfg/toreqnew/toreqnew.go
But it's not necessary to update that either unless there's a new feature ORT needs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org