[GitHub] [maven-javadoc-plugin] rovarga commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}

[GitBox <gi...@apache.org>]

rovarga commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}
URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275126814
 
 

 ##########
 File path: src/it/projects/MJAVADOC-591/pom.xml
 ##########
 @@ -0,0 +1,67 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>testcase</groupId>
+  <artifactId>javadoc-fails-with-release-and-not-source</artifactId>
+  <version>1.0-SNAPSHOT</version>
+  <packaging>bundle</packaging>
+
+  <url>https://issues.apache.org/jira/browse/MJAVADOC-591</url>
+
+  <properties>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+    <maven.compiler.release>8</maven.compiler.release>
 
 Review comment:
   I actually have some trouble getting ITs running locally and I know next to nothing about their setup -- but this IT should run with JDK9+ (via invoker.properties, if I understand correctly). The maven.compiler.release setting is correct, as it mirrors the scenario where I hit the issue -- the combination of https://github.com/opendaylight/odlparent/blob/master/odlparent/pom.xml#L1878 and https://github.com/opendaylight/yangtools/blob/master/common/concepts/pom.xml#L42 build with JDK11.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services