You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2017/09/27 03:52:44 UTC
Re: Review Request 62534: RANGER-1748 : User is unable to update
existing policy while importing policy from file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62534/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 3:52 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1748
https://issues.apache.org/jira/browse/RANGER-1748
Repository: ranger
Description
-------
Currently if user importing policy from file and user want's to update any policy for a specific resource which is not allowed.
For the given resource following rules shall apply:
1. If a policy contains one or more resources along with given resource then the policy will not be exported.
2. If a policy contains one or more resources along with given resource then the policy will not be deleted from target ranger during import call.
**Note:**
Export policy example URL: http://localhost:6080/service/plugins/policies/exportJson?serviceName=source_hive&polResource=employee&resource:database=employee&serviceType=hive&resourceMatchScope=self_or_ancestor
Import policy example URL: http://localhost:6080/service/plugins/policies/importPoliciesFromFile?updateIfExists=true&polResource=employee
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f1ce3af
Diff: https://reviews.apache.org/r/62534/diff/1/
Testing
-------
1. Verified policies are getting updated while importing from file for specific resource.
Thanks,
bhavik patel
Re: Review Request 62534: RANGER-1748 : User is unable to update
existing policy while importing policy from file
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62534/#review186448
-----------------------------------------------------------
Fix it, then Ship it!
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Lines 2274 (patched)
<https://reviews.apache.org/r/62534/#comment263003>
Add some javadoc to this method.
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Lines 2275 (patched)
<https://reviews.apache.org/r/62534/#comment263005>
Nitpick, small typo in "Policies"
- Alejandro Fernandez
On Sept. 27, 2017, 3:52 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62534/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 3:52 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1748
> https://issues.apache.org/jira/browse/RANGER-1748
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently if user importing policy from file and user want's to update any policy for a specific resource which is not allowed.
>
> For the given resource following rules shall apply:
>
> 1. If a policy contains one or more resources along with given resource then the policy will not be exported.
> 2. If a policy contains one or more resources along with given resource then the policy will not be deleted from target ranger during import call.
>
> **Note:**
> Export policy example URL: http://localhost:6080/service/plugins/policies/exportJson?serviceName=source_hive&polResource=employee&resource:database=employee&serviceType=hive&resourceMatchScope=self_or_ancestor
> Import policy example URL: http://localhost:6080/service/plugins/policies/importPoliciesFromFile?updateIfExists=true&polResource=employee
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f1ce3af
>
>
> Diff: https://reviews.apache.org/r/62534/diff/1/
>
>
> Testing
> -------
>
> 1. Verified policies are getting updated while importing from file for specific resource.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 62534: RANGER-1748 : User is unable to update
existing policy while importing policy from file
Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62534/#review186370
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On Sept. 27, 2017, 3:52 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62534/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 3:52 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1748
> https://issues.apache.org/jira/browse/RANGER-1748
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently if user importing policy from file and user want's to update any policy for a specific resource which is not allowed.
>
> For the given resource following rules shall apply:
>
> 1. If a policy contains one or more resources along with given resource then the policy will not be exported.
> 2. If a policy contains one or more resources along with given resource then the policy will not be deleted from target ranger during import call.
>
> **Note:**
> Export policy example URL: http://localhost:6080/service/plugins/policies/exportJson?serviceName=source_hive&polResource=employee&resource:database=employee&serviceType=hive&resourceMatchScope=self_or_ancestor
> Import policy example URL: http://localhost:6080/service/plugins/policies/importPoliciesFromFile?updateIfExists=true&polResource=employee
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f1ce3af
>
>
> Diff: https://reviews.apache.org/r/62534/diff/1/
>
>
> Testing
> -------
>
> 1. Verified policies are getting updated while importing from file for specific resource.
>
>
> Thanks,
>
> bhavik patel
>
>