You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2018/07/03 19:16:22 UTC
[GitHub] nifi pull request #2839: NIFI-5372 Making adjustments to the docker-compose ...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/2839
NIFI-5372 Making adjustments to the docker-compose file to allow scaling
NIFI-5372 Making adjustments to the docker-compose file to allow utilization of docker-compose up --scale. Providing a README as to how to use the docker-compose.yml
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi NIFI-5372
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2839.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2839
----
commit dd8b584e921e8912bec029503c5d4e2c99c523bb
Author: Aldrin Piri <al...@...>
Date: 2018-07-03T19:14:31Z
NIFI-5372 Making adjustments to the docker-compose file to allow utilization of docker-compose up --scale. Providing a README as to how to use the docker-compose.yml
----
---
[GitHub] nifi issue #2839: NIFI-5372 Making adjustments to the docker-compose file to...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2839
Hey @MikeThomsen,
Made some adjustments on the great work you put in earlier to help support some use cases and provided some docs. Would be interested in your input.
Thanks
---
[GitHub] nifi pull request #2839: NIFI-5372 Making adjustments to the docker-compose ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2839
---
[GitHub] nifi pull request #2839: NIFI-5372 Making adjustments to the docker-compose ...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2839#discussion_r200042921
--- Diff: nifi-docker/docker-compose/README.md ---
@@ -0,0 +1,56 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+# Apache NiFi Docker Compose
+
+# Usage
+
+## Overview
+The colocated docker-compose.yml is a [Docker Compose](https://docs.docker.com/compose/overview/) definition providing an easy way to start up an Apache NiFi Cluster.
+
+## NiFi version configuration
+There are two primary ways in which the cluster can be configured:
+
+ 1. By default, the Compose file (docker-compose.yml) is configured to make use of the latest image that would be created by a NiFi Maven build with the Docker profile activated through an invocation similar to `mvn clean install -Pdocker`.
+ 2. Optionally, a user can update the docker-compose.yml file to use a released convenience image provided in the [Apache NiFi Docker Hub repository](https://hub.docker.com/r/apache/nifi/tags/). This is accomplished by chainging the `image` property of the `nifi` service definition to be an available Docker Hub tag such as `apache/nifi:1.7.0`. **NOTE** Changes to the image can affect the expected conventions of the docker-compose.yml configuration. All released images 1.7.0 or later should work with the file as provided. If there are any issues, please file a [JIRA](https://issues.apache.org/jira/browse/NIFI).
--- End diff --
typo ``changing``
---