[jira] [Commented] (THRIFT-4659) golang race detected when closing listener socket

["Jay Gheewala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677402#comment-16677402 ] 

Jay Gheewala commented on THRIFT-4659:
--------------------------------------

[~calcifer] i have attached a potential diff that I tested locally. Let me know if that works.

Thanks,
Jay Gheewala

 

 

> golang race detected when closing listener socket
> -------------------------------------------------
>
>                 Key: THRIFT-4659
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4659
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>    Affects Versions: 0.11.0
>            Reporter: Jay Gheewala
>            Assignee: Can Celasun
>            Priority: Major
>         Attachments: THRIFT-4659.diff
>
>
> Race condition is deteced for following write/read
>  
> git.apache.org/thrift.git/lib/go/thrift/server_socket.go:119
> git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Close()
> git.apache.org/thrift.git/lib/go/thrift/server_socket.go:122
> git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Interrupt()
>  
> git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Accept()
> git.apache.org/thrift.git/lib/go/thrift/server_socket.go:78
> git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).innerAccept()
> git.apache.org/thrift.git/lib/go/thrift/simple_server.go:129
> git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).AcceptLoop()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)