You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (JIRA)" <ji...@codehaus.org> on 2011/02/04 19:03:22 UTC
[jira] Created: (MDEP-300) Unpacking artifacts should be based on
type, not on extension
Unpacking artifacts should be based on type, not on extension
-------------------------------------------------------------
Key: MDEP-300
URL: http://jira.codehaus.org/browse/MDEP-300
Project: Maven 2.x Dependency Plugin
Issue Type: Bug
Components: unpack, unpack-dependencies
Affects Versions: 2.1
Reporter: Robert Scholte
Assignee: Brian Fox
Priority: Critical
Attachments: typebased-unpack.patch
I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver.
Attached a patch which should fix this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-300) Unpacking artifacts should be based on
type, not on extension
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254689#action_254689 ]
Benjamin Bentmann commented on MDEP-300:
----------------------------------------
Unless I misunderstand, this change would break unpacking of deps of type {{test-jar}}, {{bundle}} or any other type that effectively maps to a JAR or any other well-known file extension. So maybe either both file ext and dep type should be tried to lookup the archiver or {{ArtifactItem}} should be enriched with a new field, e.g. {{archiveType}}, that allows to explicitly denote the desired archiver type.
> Unpacking artifacts should be based on type, not on extension
> -------------------------------------------------------------
>
> Key: MDEP-300
> URL: http://jira.codehaus.org/browse/MDEP-300
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.1
> Reporter: Robert Scholte
> Assignee: Brian Fox
> Priority: Critical
> Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver.
> Attached a patch which should fix this problem.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MDEP-300) Unpacking artifacts should be based on type, with
fallback on file-extension
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MDEP-300:
--------------------------------
Summary: Unpacking artifacts should be based on type, with fallback on file-extension (was: Unpacking artifacts should be based on type, not on extension)
> Unpacking artifacts should be based on type, with fallback on file-extension
> ----------------------------------------------------------------------------
>
> Key: MDEP-300
> URL: https://jira.codehaus.org/browse/MDEP-300
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.1
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Priority: Critical
> Fix For: 2.6
>
> Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver.
> Attached a patch which should fix this problem.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MDEP-300) Unpacking artifacts should be based on type, not
on extension
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte reassigned MDEP-300:
-----------------------------------
Assignee: Robert Scholte (was: Brian Fox)
> Unpacking artifacts should be based on type, not on extension
> -------------------------------------------------------------
>
> Key: MDEP-300
> URL: https://jira.codehaus.org/browse/MDEP-300
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.1
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Priority: Critical
> Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver.
> Attached a patch which should fix this problem.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MDEP-300) Unpacking artifacts should be based on type, with
fallback on file-extension
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MDEP-300.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.6
Fixed in [r1400666|http://svn.apache.org/viewvc?rev=1400666&view=rev]
> Unpacking artifacts should be based on type, with fallback on file-extension
> ----------------------------------------------------------------------------
>
> Key: MDEP-300
> URL: https://jira.codehaus.org/browse/MDEP-300
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.1
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Priority: Critical
> Fix For: 2.6
>
> Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver.
> Attached a patch which should fix this problem.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-300) Unpacking artifacts should be based on
type, not on extension
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254693#action_254693 ]
Robert Scholte commented on MDEP-300:
-------------------------------------
If there's no specific {{UnArchiver}} mapping for {{test-jar}} or {{bundle}} the patch would indeed break the unpacking of those types. Introducing something like {{archiveType}} looks a bit redundant to me. The cleanest way would be to complete the {{components.xml}} with all the well-known types, the safest way would be to first check for an {{UnArchiver}} by type, next for an {{UnArchiver}} by extension.
> Unpacking artifacts should be based on type, not on extension
> -------------------------------------------------------------
>
> Key: MDEP-300
> URL: http://jira.codehaus.org/browse/MDEP-300
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.1
> Reporter: Robert Scholte
> Assignee: Brian Fox
> Priority: Critical
> Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver.
> Attached a patch which should fix this problem.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira