You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "winterhazel (via GitHub)" <gi...@apache.org> on 2023/08/23 18:51:32 UTC

[GitHub] [cloudstack] winterhazel commented on pull request #7867: UI: Infer template settings in the deploy VM wizard

winterhazel commented on PR #7867:
URL: https://github.com/apache/cloudstack/pull/7867#issuecomment-1690474185

   > I always thought, the backend would infer the template specific details/settings ?
   
   @rohityadavcloud 
   The backend infers the setings when the parameters in the API call are null. 
   
   The problem is that the deploy VM wizard always defaults the boot type and mode to BIOS and LEGACY, even if they are set to something else in the template. For that reason, these two settings are not being inherited when deploying a VM through the UI.
   
   > @winterhazel , will you apply @Pearl1594 's suggestion?
   
   @Pearl1594 @DaanHoogland
   I have checked how the backend infers this setting and I think that it is better to change this line to `this.form.iothreadsenabled = Object.prototype.hasOwnProperty.call(template, 'iothreads')` to match its behavior. The backend considers iothreads as enabled when the VM details contain the key "iothreads", independently of its value.
   
   With the current changes, if "iothreads" is set to "example", the UI will set the parameter to false. With @Pearl1594 's suggestion, the UI will not infer it, but the backend will infer it as enabled since the parameter in the API call was null. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org