You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/05/26 08:22:03 UTC
[kudu-CR](branch-1.17.x) [tests] Fix flakiness in log-rolling-itest.cc
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19943
to review the following change.
Change subject: [tests] Fix flakiness in log-rolling-itest.cc
......................................................................
[tests] Fix flakiness in log-rolling-itest.cc
The test TestLogCleanupOnStartup within log-rolling-itest.cc
has been flaky with a 30% failure rate for the last 2+ weeks.
The timeout within the test was increased from 30 to 60 seconds
to allow the ExcessLogFileDeleterThread to have enough time to
properly clean up the log files.
Below are the dist-test stats for a DEBUG build.
Before: 13/100 failed.
http://dist-test.cloudera.org/job?job_id=mreddy.1683141191.148826
After: 0/100 failed.
http://dist-test.cloudera.org/job?job_id=mreddy.1683146152.19719
Change-Id: I4d33559fa01c26d8c8b3ad12b8822d2cdd760fae
Reviewed-on: http://gerrit.cloudera.org:8080/19842
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/19943/1
--
To view, visit http://gerrit.cloudera.org:8080/19943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d33559fa01c26d8c8b3ad12b8822d2cdd760fae
Gerrit-Change-Number: 19943
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.17.x) [tests] Fix flakiness in log-rolling-itest.cc
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19943 )
Change subject: [tests] Fix flakiness in log-rolling-itest.cc
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d33559fa01c26d8c8b3ad12b8822d2cdd760fae
Gerrit-Change-Number: 19943
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 26 May 2023 11:14:36 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tests] Fix flakiness in log-rolling-itest.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19943 )
Change subject: [tests] Fix flakiness in log-rolling-itest.cc
......................................................................
[tests] Fix flakiness in log-rolling-itest.cc
The test TestLogCleanupOnStartup within log-rolling-itest.cc
has been flaky with a 30% failure rate for the last 2+ weeks.
The timeout within the test was increased from 30 to 60 seconds
to allow the ExcessLogFileDeleterThread to have enough time to
properly clean up the log files.
Below are the dist-test stats for a DEBUG build.
Before: 13/100 failed.
http://dist-test.cloudera.org/job?job_id=mreddy.1683141191.148826
After: 0/100 failed.
http://dist-test.cloudera.org/job?job_id=mreddy.1683146152.19719
Change-Id: I4d33559fa01c26d8c8b3ad12b8822d2cdd760fae
Reviewed-on: http://gerrit.cloudera.org:8080/19842
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/19943
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d33559fa01c26d8c8b3ad12b8822d2cdd760fae
Gerrit-Change-Number: 19943
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [tests] Fix flakiness in log-rolling-itest.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19943 )
Change subject: [tests] Fix flakiness in log-rolling-itest.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d33559fa01c26d8c8b3ad12b8822d2cdd760fae
Gerrit-Change-Number: 19943
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 26 May 2023 21:40:10 +0000
Gerrit-HasComments: No