[GitHub] [beam] alexvanboxel commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options

[GitBox <gi...@apache.org>]

alexvanboxel commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options
URL: https://github.com/apache/beam/pull/10529#discussion_r397748991
 
 

 ##########
 File path: sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java
 ##########
 @@ -205,10 +205,12 @@ static Schema getSchema(Descriptors.Descriptor descriptor) {
         // Store proto field number in metadata.
         FieldType fieldType =
             withMetaData(beamFieldTypeFromProtoField(fieldDescriptor), fieldDescriptor);
 
 Review comment:
   Now all the options are prefix. I moved the removal of the metadata to another ticket, because it's more involved:
   
   [BEAM-9604] BIP-1: Remove schema metadata usage for Protobuf extension
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services