You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Tommaso Teofili <to...@gmail.com> on 2014/02/28 11:22:26 UTC
Re: svn commit: r1572903 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
awesome commit message Alex :)
Tommaso
2014-02-28 11:20 GMT+01:00 <al...@apache.org>:
> Author: alexparvulescu
> Date: Fri Feb 28 10:20:03 2014
> New Revision: 1572903
>
> URL: http://svn.apache.org/r1572903
> Log:
> OAK-1472 ConcurrentAddReferenceTest#addReferences still fails
> - enabling test to see it fail, you only live once
>
> Modified:
>
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
>
> Modified:
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> URL:
> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java?rev=1572903&r1=1572902&r2=1572903&view=diff
>
> ==============================================================================
> ---
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> (original)
> +++
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> Fri Feb 28 10:20:03 2014
> @@ -28,7 +28,6 @@ import javax.jcr.nodetype.NodeType;
>
> import org.junit.After;
> import org.junit.Before;
> -import org.junit.Ignore;
> import org.junit.Test;
>
> import com.google.common.collect.Iterators;
> @@ -38,7 +37,7 @@ import static org.junit.Assert.assertEqu
> import static org.junit.Assert.fail;
>
> /**
> - * <code>ConcurrentAddIT</code> adds nodes with multiple sessions in
> separate
> + * <code>ConcurrentAddReferenceTest</code> adds nodes with multiple
> sessions in separate
> * locations of the repository and creates references to a single node.
> */
> public class ConcurrentAddReferenceTest extends AbstractRepositoryTest {
> @@ -73,7 +72,6 @@ public class ConcurrentAddReferenceTest
>
> @SuppressWarnings("unchecked")
> @Test
> - @Ignore("OAK-1472") // FIXME OAK-1472
> public void addReferences() throws Exception {
> List<Exception> exceptions = Collections.synchronizedList(new
> ArrayList<Exception>());
> Node test = getAdminSession().getRootNode().addNode("test");
>
>
>
Re: svn commit: r1572903 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
Posted by Alex Parvulescu <al...@gmail.com>.
thanks :)
unfortunately it did not work as expected, the test still fails, it was
worth a try though.
alex
On Fri, Feb 28, 2014 at 11:22 AM, Tommaso Teofili <tommaso.teofili@gmail.com
> wrote:
> awesome commit message Alex :)
>
> Tommaso
>
>
> 2014-02-28 11:20 GMT+01:00 <al...@apache.org>:
>
> > Author: alexparvulescu
> > Date: Fri Feb 28 10:20:03 2014
> > New Revision: 1572903
> >
> > URL: http://svn.apache.org/r1572903
> > Log:
> > OAK-1472 ConcurrentAddReferenceTest#addReferences still fails
> > - enabling test to see it fail, you only live once
> >
> > Modified:
> >
> >
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> >
> > Modified:
> >
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> > URL:
> >
> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java?rev=1572903&r1=1572902&r2=1572903&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> > (original)
> > +++
> >
> jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ConcurrentAddReferenceTest.java
> > Fri Feb 28 10:20:03 2014
> > @@ -28,7 +28,6 @@ import javax.jcr.nodetype.NodeType;
> >
> > import org.junit.After;
> > import org.junit.Before;
> > -import org.junit.Ignore;
> > import org.junit.Test;
> >
> > import com.google.common.collect.Iterators;
> > @@ -38,7 +37,7 @@ import static org.junit.Assert.assertEqu
> > import static org.junit.Assert.fail;
> >
> > /**
> > - * <code>ConcurrentAddIT</code> adds nodes with multiple sessions in
> > separate
> > + * <code>ConcurrentAddReferenceTest</code> adds nodes with multiple
> > sessions in separate
> > * locations of the repository and creates references to a single node.
> > */
> > public class ConcurrentAddReferenceTest extends AbstractRepositoryTest {
> > @@ -73,7 +72,6 @@ public class ConcurrentAddReferenceTest
> >
> > @SuppressWarnings("unchecked")
> > @Test
> > - @Ignore("OAK-1472") // FIXME OAK-1472
> > public void addReferences() throws Exception {
> > List<Exception> exceptions = Collections.synchronizedList(new
> > ArrayList<Exception>());
> > Node test = getAdminSession().getRootNode().addNode("test");
> >
> >
> >
>