You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Eiji Takahashi (JIRA)" <ji...@apache.org> on 2010/11/25 08:36:15 UTC
[jira] Created: (DBCP-348) connectionInitSqls doesn't work
correctly.
connectionInitSqls doesn't work correctly.
-------------------------------------------
Key: DBCP-348
URL: https://issues.apache.org/jira/browse/DBCP-348
Project: Commons Dbcp
Issue Type: Bug
Affects Versions: 1.4, 1.3
Environment: CentOS 5.4
JDK 6u21
Reporter: Eiji Takahashi
Priority: Minor
The parameter name is different between the source code and the online document.
Souce code(BasicDataSourceFactory.java):
private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
Online document(http://commons.apache.org/dbcp/configuration.html):
Parameter name: connectionInitSqls
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Issue Comment Edited] (DBCP-348) connectionInitSqls doesn't
work correctly.
Posted by "Artem Shnayder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039874#comment-13039874 ]
Artem Shnayder edited comment on DBCP-348 at 5/26/11 7:25 PM:
--------------------------------------------------------------
Just ran into this issue as well. Something else I've noticed is that although BasicDataSource expects a List of Strings, BasicDataSourceFactory expects a String with semi-colon delimiters. That difference should be documented or fixed as well.
was (Author: shndr):
Just ran into this issue as well. Something else I've noticed is that although BasicDataSource expects a List of Strings, BasicDataSourceFactory expects a String with semi-colon delimeters. That difference should be documented or fixed as well.
> connectionInitSqls doesn't work correctly.
> -------------------------------------------
>
> Key: DBCP-348
> URL: https://issues.apache.org/jira/browse/DBCP-348
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.3, 1.4
> Environment: CentOS 5.4
> JDK 6u21
> Reporter: Eiji Takahashi
> Priority: Minor
> Fix For: 1.3.1, 1.4.1
>
> Attachments: connectionInitSqls.patch
>
>
> The parameter name is different between the source code and the online document.
> Souce code(BasicDataSourceFactory.java):
> private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
> Online document(http://commons.apache.org/dbcp/configuration.html):
> Parameter name: connectionInitSqls
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DBCP-348) connectionInitSqls doesn't work
correctly.
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935857#action_12935857 ]
Phil Steitz commented on DBCP-348:
----------------------------------
Thanks for the patch!
Fixed in r1039158 in the 1.4.x branch and trunk (2.0). I added a note to the current config docs pointing out the problem.
Leaving open until 1.3.1/1.4.1 are released, at which time the config note needs to be removed from configuration.xml.
Technically, this is an incompatible change; but I see it as an API bug that makes the 1.3/1.4 API unusable without looking at the internals, so the formal compatibility break is warranted in 1.3.1/1.4.1
> connectionInitSqls doesn't work correctly.
> -------------------------------------------
>
> Key: DBCP-348
> URL: https://issues.apache.org/jira/browse/DBCP-348
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.3, 1.4
> Environment: CentOS 5.4
> JDK 6u21
> Reporter: Eiji Takahashi
> Priority: Minor
> Attachments: connectionInitSqls.patch
>
>
> The parameter name is different between the source code and the online document.
> Souce code(BasicDataSourceFactory.java):
> private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
> Online document(http://commons.apache.org/dbcp/configuration.html):
> Parameter name: connectionInitSqls
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DBCP-348) connectionInitSqls doesn't work
correctly.
Posted by "Eiji Takahashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eiji Takahashi updated DBCP-348:
--------------------------------
Attachment: connectionInitSqls.patch
change parameter name from 'initConnectionSqls' to 'connectionInitSqls'
> connectionInitSqls doesn't work correctly.
> -------------------------------------------
>
> Key: DBCP-348
> URL: https://issues.apache.org/jira/browse/DBCP-348
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.3, 1.4
> Environment: CentOS 5.4
> JDK 6u21
> Reporter: Eiji Takahashi
> Priority: Minor
> Attachments: connectionInitSqls.patch
>
>
> The parameter name is different between the source code and the online document.
> Souce code(BasicDataSourceFactory.java):
> private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
> Online document(http://commons.apache.org/dbcp/configuration.html):
> Parameter name: connectionInitSqls
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (DBCP-348) connectionInitSqls doesn't work
correctly.
Posted by "Artem Shnayder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039874#comment-13039874 ]
Artem Shnayder commented on DBCP-348:
-------------------------------------
Just ran into this issue as well. Something else I've noticed is that although BasicDataSource expects a List of Strings, BasicDataSourceFactory expects a String with semi-colon delimeters. That difference should be documented or fixed as well.
> connectionInitSqls doesn't work correctly.
> -------------------------------------------
>
> Key: DBCP-348
> URL: https://issues.apache.org/jira/browse/DBCP-348
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.3, 1.4
> Environment: CentOS 5.4
> JDK 6u21
> Reporter: Eiji Takahashi
> Priority: Minor
> Fix For: 1.3.1, 1.4.1
>
> Attachments: connectionInitSqls.patch
>
>
> The parameter name is different between the source code and the online document.
> Souce code(BasicDataSourceFactory.java):
> private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
> Online document(http://commons.apache.org/dbcp/configuration.html):
> Parameter name: connectionInitSqls
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DBCP-348) connectionInitSqls doesn't work
correctly.
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz updated DBCP-348:
-----------------------------
Fix Version/s: 1.4.1
1.3.1
> connectionInitSqls doesn't work correctly.
> -------------------------------------------
>
> Key: DBCP-348
> URL: https://issues.apache.org/jira/browse/DBCP-348
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.3, 1.4
> Environment: CentOS 5.4
> JDK 6u21
> Reporter: Eiji Takahashi
> Priority: Minor
> Fix For: 1.3.1, 1.4.1
>
> Attachments: connectionInitSqls.patch
>
>
> The parameter name is different between the source code and the online document.
> Souce code(BasicDataSourceFactory.java):
> private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
> Online document(http://commons.apache.org/dbcp/configuration.html):
> Parameter name: connectionInitSqls
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.