You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/18 23:51:53 UTC
Review Request 19336: Force disable C++11 in mesos for g++-4.7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37663
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 18, 2014, 11:25 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 11:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On March 19, 2014, 12:18 p.m., Benjamin Hindman wrote:
> > configure.ac, line 287
> > <https://reviews.apache.org/r/19336/diff/5/?file=526616#file526616line287>
> >
> > Can we easily print a warning message out? This seems a bit implicit for me, especially if someone explicitly set --with-cxx11. I suppose, however, that the same was true if someone explicitly set --without-cxx11 when using clang. Ideally if someone requests something we fail rather than ignore their request just to "make it work".
in both the clang and g++ 4.7 we could fail with an error message if you prefer.
your comment suggests adding a warning and also failing so which would you like to see? i agree a warning is the minimum required.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37764
-----------------------------------------------------------
On March 19, 2014, 12:10 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 12:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37764
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/19336/#comment69464>
Any reason not to nest this with the GCC stuff below?
configure.ac
<https://reviews.apache.org/r/19336/#comment69465>
Can we wrap this at 80 characters please?
configure.ac
<https://reviews.apache.org/r/19336/#comment69466>
This stuff is all really dense, for readability can we put a newline above here.
configure.ac
<https://reviews.apache.org/r/19336/#comment69477>
Wrap at 80 characters please.
configure.ac
<https://reviews.apache.org/r/19336/#comment69467>
Let's put a newline above this as well please.
configure.ac
<https://reviews.apache.org/r/19336/#comment69475>
Can we easily print a warning message out? This seems a bit implicit for me, especially if someone explicitly set --with-cxx11. I suppose, however, that the same was true if someone explicitly set --without-cxx11 when using clang. Ideally if someone requests something we fail rather than ignore their request just to "make it work".
- Benjamin Hindman
On March 19, 2014, 7:10 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 7:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37910
-----------------------------------------------------------
Ship it!
I think the warning is probably fine for now, this will keep Mesos building for most people even with our defaults and we can revisit later if necessary.
- Benjamin Hindman
On March 19, 2014, 8:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37861
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19336]
All tests passed.
- Mesos ReviewBot
On March 19, 2014, 8:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 20, 2014, 10:47 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
added dependency
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 19, 2014, 1:12 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 19, 2014, 12:10 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37685
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19336]
All tests passed.
- Mesos ReviewBot
On March 19, 2014, 12:32 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 12:32 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 5:32 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37665
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19335, 19336]
All tests passed.
- Mesos ReviewBot
On March 18, 2014, 11:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 11:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1095 and MESOS-1121
> https://issues.apache.org/jira/browse/MESOS-1095
> https://issues.apache.org/jira/browse/MESOS-1121
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> m4/ax_compare_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19336/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER=''
>
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 4:35 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 4:34 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 4:33 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 4:32 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
rebased to master
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e814e451427322fb1390802cd284303631019fcb
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 4:27 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon
Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/
-----------------------------------------------------------
(Updated March 18, 2014, 4:25 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1095 and MESOS-1121
https://issues.apache.org/jira/browse/MESOS-1095
https://issues.apache.org/jira/browse/MESOS-1121
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
m4/ax_compare_version.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/19336/diff/
Testing
-------
make check GTEST_FILTER=''
clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
Thanks,
Dominic Hamon