You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jv...@apache.org on 2009/04/01 21:09:55 UTC
svn commit: r761017 -
/maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
Author: jvanzyl
Date: Wed Apr 1 19:09:55 2009
New Revision: 761017
URL: http://svn.apache.org/viewvc?rev=761017&view=rev
Log:
o nuke the path translator from the plugin manager.
Modified:
maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
Modified: maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
URL: http://svn.apache.org/viewvc/maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java?rev=761017&r1=761016&r2=761017&view=diff
==============================================================================
--- maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java (original)
+++ maven/components/branches/MNG-2766/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java Wed Apr 1 19:09:55 2009
@@ -76,6 +76,11 @@
import org.codehaus.plexus.util.StringUtils;
import org.codehaus.plexus.util.xml.Xpp3Dom;
+//TODO: separate out project downloading
+//TODO: template method plugin validation as its framework specific
+//TODO: provide a method to get default configuraiton for a given plugin
+//TODO: get rid of all the custom configuration merging here, that's domain specific but needs to incorporate defaults the plugin manager can provide
+
@Component(role = PluginManager.class)
public class DefaultPluginManager
implements PluginManager
@@ -89,9 +94,6 @@
@Requirement
protected ArtifactFilterManager coreArtifactFilterManager;
- //@Requirement
- //protected PathTranslator pathTranslator;
-
@Requirement
protected MavenPluginCollector pluginCollector;
@@ -349,12 +351,6 @@
logger.warn( "Mojo: " + mojoDescriptor.getGoal() + " is deprecated.\n" + mojoDescriptor.getDeprecated() );
}
- /*
- Model model = project.getModel();
- pathTranslator.alignToBaseDirectory( model, project.getBasedir() );
- project.setBuild( model.getBuild() );
- */
-
if ( mojoDescriptor.isDependencyResolutionRequired() != null )
{
try