You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2024/09/19 09:15:37 UTC
[PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
zhangstar333 opened a new pull request, #41004:
URL: https://github.com/apache/doris/pull/41004
## Proposed changes
when return type is array_string, the nested column string offset is should be cumulative, start with offset[row-1]
instead of start at 0
this bug only in branch-2.0
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360548213
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 89b7fc6c35e914c9411701fb11069cf3506e88cb with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360502737
<details>
<summary>TPC-H: <b>Total hot run time: 49141 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 89b7fc6c35e914c9411701fb11069cf3506e88cb, data reload: false
------ Round 1 ----------------------------------
q1 17972 4458 4495 4458
q2 2185 162 147 147
q3 11497 1944 1979 1944
q4 10112 1298 1351 1298
q5 8658 3919 3854 3854
q6 230 126 124 124
q7 2070 1605 1642 1605
q8 9578 2736 2712 2712
q9 13481 9861 9658 9658
q10 8631 3482 3525 3482
q11 420 249 252 249
q12 475 291 300 291
q13 18364 3972 4031 3972
q14 359 328 324 324
q15 512 456 452 452
q16 532 449 455 449
q17 1132 984 994 984
q18 7297 6858 6872 6858
q19 1700 1552 1501 1501
q20 516 314 312 312
q21 4455 4122 4077 4077
q22 497 402 390 390
Total cold run time: 120673 ms
Total hot run time: 49141 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4321 4300 4312 4300
q2 318 223 224 223
q3 4152 4124 4138 4124
q4 2760 2740 2740 2740
q5 7083 7028 7052 7028
q6 237 121 126 121
q7 3228 2815 2797 2797
q8 4317 4419 4417 4417
q9 13635 13507 13499 13499
q10 4200 4236 4290 4236
q11 710 675 679 675
q12 1013 860 832 832
q13 6794 3738 3757 3738
q14 457 435 420 420
q15 493 457 462 457
q16 642 598 599 598
q17 3745 3756 3738 3738
q18 8751 8760 8826 8760
q19 1727 1687 1671 1671
q20 2387 2134 2131 2131
q21 8425 8438 8339 8339
q22 1026 921 954 921
Total cold run time: 80421 ms
Total hot run time: 75765 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360456178
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360581191
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360541408
<details>
<summary>ClickBench: <b>Total hot run time: 30.7 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 89b7fc6c35e914c9411701fb11069cf3506e88cb, data reload: false
query1 0.02 0.02 0.02
query2 0.07 0.02 0.02
query3 0.24 0.04 0.04
query4 1.79 0.06 0.07
query5 0.53 0.52 0.53
query6 1.23 0.62 0.67
query7 0.01 0.00 0.01
query8 0.04 0.03 0.03
query9 0.52 0.48 0.47
query10 0.52 0.53 0.54
query11 0.12 0.09 0.09
query12 0.11 0.09 0.09
query13 0.62 0.61 0.61
query14 0.78 0.79 0.78
query15 0.77 0.76 0.76
query16 0.37 0.39 0.37
query17 1.01 0.99 1.04
query18 0.22 0.24 0.25
query19 1.94 1.83 1.83
query20 0.01 0.01 0.02
query21 15.47 0.54 0.52
query22 2.37 2.66 1.81
query23 17.34 1.04 0.92
query24 6.70 0.83 1.12
query25 0.39 0.12 0.04
query26 0.74 0.16 0.16
query27 0.04 0.03 0.04
query28 6.41 0.73 0.75
query29 12.61 2.32 2.26
query30 0.56 0.54 0.52
query31 2.81 0.39 0.38
query32 3.37 0.49 0.50
query33 3.07 3.08 3.07
query34 15.26 4.81 4.78
query35 4.88 4.87 4.84
query36 1.06 1.03 1.00
query37 0.06 0.04 0.05
query38 0.04 0.02 0.02
query39 0.02 0.01 0.02
query40 0.16 0.14 0.14
query41 0.07 0.01 0.02
query42 0.02 0.02 0.01
query43 0.02 0.01 0.02
Total cold run time: 104.39 s
Total hot run time: 30.7 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360530007
<details>
<summary>TPC-DS: <b>Total hot run time: 212612 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 89b7fc6c35e914c9411701fb11069cf3506e88cb, data reload: false
query1 927 397 414 397
query2 6530 2361 2114 2114
query3 6927 208 206 206
query4 23409 21875 22256 21875
query5 19742 6492 6575 6492
query6 281 221 222 221
query7 4327 302 296 296
query8 254 282 277 277
query9 3053 2638 2585 2585
query10 480 316 289 289
query11 15933 15060 15342 15060
query12 122 76 73 73
query13 1031 434 435 434
query14 17900 13413 13091 13091
query15 360 215 233 215
query16 6464 287 260 260
query17 1745 911 888 888
query18 894 316 317 316
query19 213 158 156 156
query20 84 81 79 79
query21 194 95 96 95
query22 5216 5111 5023 5023
query23 34333 33831 33316 33316
query24 7497 6305 6313 6305
query25 510 438 424 424
query26 1128 163 160 160
query27 2296 299 298 298
query28 6085 2271 2221 2221
query29 2793 2668 2809 2668
query30 239 168 164 164
query31 944 736 728 728
query32 69 63 63 63
query33 443 270 271 270
query34 858 477 471 471
query35 1106 951 941 941
query36 1336 1068 1273 1068
query37 92 58 62 58
query38 3092 2896 2951 2896
query39 1387 1341 1300 1300
query40 311 100 98 98
query41 40 36 36 36
query42 93 81 94 81
query43 595 591 571 571
query44 1150 728 733 728
query45 245 231 235 231
query46 1227 945 972 945
query47 1870 2000 1680 1680
query48 505 407 403 403
query49 642 384 384 384
query50 853 682 662 662
query51 4753 4669 4675 4669
query52 87 76 75 75
query53 245 194 185 185
query54 2682 2488 2512 2488
query55 94 83 83 83
query56 226 209 211 209
query57 1177 1195 1169 1169
query58 228 209 225 209
query59 3452 3233 3516 3233
query60 212 207 205 205
query61 95 93 97 93
query62 798 472 504 472
query63 197 175 174 174
query64 3503 1598 1343 1343
query65 3634 3581 3567 3567
query66 772 447 419 419
query67 15763 14991 15026 14991
query68 10742 697 662 662
query69 497 270 278 270
query70 1690 1574 1406 1406
query71 405 315 311 311
query72 6901 4785 4922 4785
query73 771 325 338 325
query74 6247 5846 5887 5846
query75 5326 3697 3733 3697
query76 6496 1186 1223 1186
query77 1109 266 258 258
query78 12490 12550 11889 11889
query79 10488 654 679 654
query80 677 394 389 389
query81 491 239 239 239
query82 1149 99 100 99
query83 167 136 137 136
query84 258 69 69 69
query85 761 316 327 316
query86 327 301 295 295
query87 3236 3015 3077 3015
query88 4973 2417 2401 2401
query89 423 278 302 278
query90 1954 217 217 217
query91 161 131 128 128
query92 59 51 51 51
query93 5956 558 609 558
query94 713 210 207 207
query95 2017 2079 1967 1967
query96 655 341 333 333
query97 6396 6329 6401 6329
query98 216 213 211 211
query99 2878 963 889 889
Total cold run time: 322372 ms
Total hot run time: 212612 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41004:
URL: https://github.com/apache/doris/pull/41004#issuecomment-2360455654
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](branch-20) fix udf return array_string type has error in branch-20 [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #41004:
URL: https://github.com/apache/doris/pull/41004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org