You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/20 06:41:28 UTC

[GitHub] [beam] davidak09 commented on pull request #12050: [BEAM-10292] DefaultFilenamePolicy.ParamsCoder is not able to decode directory on the local file system

davidak09 commented on pull request #12050:
URL: https://github.com/apache/beam/pull/12050#issuecomment-677319416


   > We should update LocalResourceId and drop the isDirectory field
   
   I removed the `isDirectory` field, nevertheless I left `isDirectory` parameter in the constructor and the factory method untouched. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org