[jira] [Commented] (FELIX-5768) DM Lambda stop callback not being called

["Pierre De Rop (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315511#comment-16315511 ] 

Pierre De Rop commented on FELIX-5768:
--------------------------------------

Added the following testcase in revision 1820507, which reproduces the issue.

org.apache.felix.dm.lambda.itest.StopCallbackTest

> DM Lambda stop callback not being called
> ----------------------------------------
>
>                 Key: FELIX-5768
>                 URL: https://issues.apache.org/jira/browse/FELIX-5768
>             Project: Felix
>          Issue Type: Bug
>          Components: Dependency Manager Lambda
>    Affects Versions: org.apache.felix.dependencymanager-r8
>            Reporter: Pierre De Rop
>            Assignee: Pierre De Rop
>            Priority: Blocker
>
> It has been reported from the felix users mailing list an issue where a component defined with dm-lambda API is never called in its "stop" callback when the bundle is stopped.
> indeed, the dm-lambda DependencyManagerActivator.stop method has a bug and does not clear the dependency manager when the bundle is stopped: the current code of the DependencyManagerActivator.stop method is this:
> {code}
>     public void stop(BundleContext context) throws Exception {
>         destroy();
>     }
> {code}
> and of course, the manager must be cleared, like it is the case with the original DependencyActivatorBase.stop method:
> {code}
>     public void stop(BundleContext context) throws Exception {
>         destroy();
>         m_manager.clear();
>     }
> {code}
> it is too bad that no tests were testing this so basic behavior, so I will first add it soon.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)