[jira] [Commented] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger

["Karan Mehta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571194#comment-16571194 ] 

Karan Mehta commented on PHOENIX-4834:
--------------------------------------

[~tdsilva] [~vincentpoon] Please review. 

> PhoenixMetricsLog interface methods should not depend on specific logger
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-4834
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4834
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.0
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Major
>             Fix For: 4.15.0
>
>         Attachments: PHOENIX-4834.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various JDBC objects with logging functionality upon close/commit. The methods take in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of doing is that the interface should just pass the metrics and allow the user to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default implementation for them and add the new methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)