You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by nd...@apache.org on 2020/03/31 16:36:05 UTC
[hbase] branch branch-2.3 updated (9fb020f -> 4affd65)
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a change to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git.
from 9fb020f HBASE-24079 [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add waits on quota table to come online; etc.
new 7f65f40 HBASE-20467 Precommit personality should only run checkstyle once if we're going to run it at the root
new 4affd65 HBASE-24078 SpotBugs check automatically skip inapplicable modules
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
dev-support/hbase-personality.sh | 24 ++++++------------------
1 file changed, 6 insertions(+), 18 deletions(-)
[hbase] 02/02: HBASE-24078 SpotBugs check automatically skip
inapplicable modules
Posted by nd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 4affd65074d837494c7410ef9ff7166974127d80
Author: Nick Dimiduk <nd...@apache.org>
AuthorDate: Wed Mar 25 15:45:28 2020 -0700
HBASE-24078 SpotBugs check automatically skip inapplicable modules
Without patch, the spotbugs results include warnings for inapplicable
modules:
+---------------------------------------------------------------------------
| | | | Compile Tests
+---------------------------------------------------------------------------
| 0 | mvndep | 0m 11s | Maven dependency ordering
| +1 | mvninstall | 2m 47s | the source passed
| 0 | spotbugs | 0m 11s | branch/hbase-annotations no spotbugs
| | | | output file (spotbugsXml.xml)
| 0 | spotbugs | 0m 14s | branch/hbase-assembly no spotbugs output
| | | | file (spotbugsXml.xml)
| 0 | spotbugs | 0m 07s |
| | | | branch/hbase-archetypes/hbase-archetype-bu
| | | | ilder no spotbugs output file
| | | | (spotbugsXml.xml)
+---------------------------------------------------------------------------
With patch,
+---------------------------------------------------------------------------
| | | | Compile Tests
+---------------------------------------------------------------------------
| 0 | mvndep | 0m 13s | Maven dependency ordering
| +1 | mvninstall | 3m 09s | the source passed
| +1 | spotbugs | 17m 09s | the source passed
+---------------------------------------------------------------------------
Signed-off-by: stack <st...@apache.org>
---
dev-support/hbase-personality.sh | 25 ++++++-------------------
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 3fe9fd9..ec05187 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -153,8 +153,8 @@ function personality_modules
# If BUILDMODE is 'patch', for unit and compile testtypes, there is no need to run individual
# modules if root is included. HBASE-18505
if [[ "${BUILDMODE}" == "full" ]] || \
- ( ( [[ "${testtype}" == unit ]] || [[ "${testtype}" == compile ]] || [[ "${testtype}" == checkstyle ]] ) && \
- [[ "${MODULES[*]}" =~ \. ]] ); then
+ { { [[ "${testtype}" == unit ]] || [[ "${testtype}" == compile ]] || [[ "${testtype}" == checkstyle ]]; } && \
+ [[ "${MODULES[*]}" =~ \. ]]; }; then
MODULES=(.)
fi
@@ -190,23 +190,10 @@ function personality_modules
# For some reason, spotbugs on root is not working, but running on individual modules is
# working. For time being, let it run on original list of CHANGED_MODULES. HBASE-19491
for module in "${CHANGED_MODULES[@]}"; do
- # skip spotbugs on hbase-shell and hbase-it. hbase-it has nothing
- # in src/main/java where spotbugs goes to look
- # skip hbase-shaded* as there is no java code in them
- # skip all modules with no java code or at least, non test java code
- if [[ ${module} == hbase-shell ]]; then
- continue
- elif [[ ${module} == hbase-it ]]; then
- continue
- elif [[ ${module} == hbase-shaded* ]]; then
- continue
- elif [[ ${module} == hbase-build-configuration ]]; then
- continue
- elif [[ ${module} == hbase-checkstyle ]]; then
- continue
- elif [[ ${module} == hbase-resource-bundle ]]; then
- continue
- elif [[ ${module} == hbase-testing-util ]]; then
+ # skip spotbugs on any module that lacks content in `src/main/java`
+ if [[ "$(find "${BASEDIR}/${module}" -iname '*.java' -and -ipath '*/src/main/java/*' \
+ -type f | wc -l | tr -d '[:space:]')" -eq 0 ]]; then
+ yetus_debug "no java files found under ${module}/src/main/java. skipping."
continue
else
# shellcheck disable=SC2086
[hbase] 01/02: HBASE-20467 Precommit personality should only run
checkstyle once if we're going to run it at the root
Posted by nd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 7f65f4003b1886283dd97af10a9c488b7cbcd881
Author: Nihal Jain <ni...@gmail.com>
AuthorDate: Sat Apr 21 03:41:13 2018 +0530
HBASE-20467 Precommit personality should only run checkstyle once if we're going to run it at the root
Signed-off-by: Sean Busbey <bu...@apache.org>
---
dev-support/hbase-personality.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 72f0b05..3fe9fd9 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -153,7 +153,8 @@ function personality_modules
# If BUILDMODE is 'patch', for unit and compile testtypes, there is no need to run individual
# modules if root is included. HBASE-18505
if [[ "${BUILDMODE}" == "full" ]] || \
- [[ ( "${testtype}" == unit || "${testtype}" == compile ) && "${MODULES[*]}" =~ \. ]]; then
+ ( ( [[ "${testtype}" == unit ]] || [[ "${testtype}" == compile ]] || [[ "${testtype}" == checkstyle ]] ) && \
+ [[ "${MODULES[*]}" =~ \. ]] ); then
MODULES=(.)
fi