[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #258: add unit test for big decimal in map

[GitBox <gi...@apache.org>]

wongoo commented on a change in pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258#discussion_r587948941



##########
File path: map.go
##########
@@ -245,12 +245,12 @@ func (d *Decoder) decMap(flag int32) (interface{}, error) {
 	case tag == BC_REF:
 		return d.decRef(int32(tag))
 	case tag == BC_MAP:
-		if t, err = d.decType(); err != nil {

Review comment:
       should reset

##########
File path: go.mod
##########
@@ -6,3 +6,4 @@ require (
 	github.com/stretchr/testify v1.4.0
 )
 
+go 1.13

Review comment:
       not add go version




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org