You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/04/03 17:44:04 UTC
Review Request 32816: Ambari UI for HBase config incorrectly
describes the -Xmn config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32816/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-10350
https://issues.apache.org/jira/browse/AMBARI-10350
Repository: ambari
Description
-------
Ambari GUI for HBase config incorrectly describes the -Xmn as the “maximum value for the minimum heap size”, which is incorrect. Xmn is the size of the heap for the young generation.
If somebody new to Java just reads the Ambari description and set both Xmn and Xmx to the same value, HBase will start but it will perform miserably. Please fix the documentation for the two settings in Ambari GUI that refer to Xmx (the ratio and the static value)
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 307cb15
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 7ed92ed
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/configuration/hbase-env.xml 7218deb
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml a1725e4
ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/HBASE/configuration/hbase-env.xml 2e92f56
ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HBASE/configuration/global.xml aff79f2
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/configuration/global.xml cc4baf4
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/configuration/global.xml 3a54dcb
Diff: https://reviews.apache.org/r/32816/diff/
Testing
-------
manual check
Thanks,
Dmitro Lisnichenko
Re: Review Request 32816: Ambari UI for HBase config incorrectly
describes the -Xmn config
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32816/#review78793
-----------------------------------------------------------
This is more accurate and readable than before.
One thing:
"Percentage of max heap size which used for young generation heap (-Xmx)"
This doesn't look right.
Shouldn't it be someting like:
"Percentage of max heap size (-Xmx) which used for young generation heap (-Xmn)"
- Yusaku Sako
On April 3, 2015, 3:44 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32816/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 3:44 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-10350
> https://issues.apache.org/jira/browse/AMBARI-10350
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari GUI for HBase config incorrectly describes the -Xmn as the “maximum value for the minimum heap size”, which is incorrect. Xmn is the size of the heap for the young generation.
> If somebody new to Java just reads the Ambari description and set both Xmn and Xmx to the same value, HBase will start but it will perform miserably. Please fix the documentation for the two settings in Ambari GUI that refer to Xmx (the ratio and the static value)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 307cb15
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 7ed92ed
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/configuration/hbase-env.xml 7218deb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml a1725e4
> ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/HBASE/configuration/hbase-env.xml 2e92f56
> ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HBASE/configuration/global.xml aff79f2
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/configuration/global.xml cc4baf4
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/configuration/global.xml 3a54dcb
>
> Diff: https://reviews.apache.org/r/32816/diff/
>
>
> Testing
> -------
>
> manual check
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 32816: Ambari UI for HBase config incorrectly
describes the -Xmn config
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32816/#review78909
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On April 6, 2015, 10:27 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32816/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 10:27 a.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-10350
> https://issues.apache.org/jira/browse/AMBARI-10350
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari GUI for HBase config incorrectly describes the -Xmn as the “maximum value for the minimum heap size”, which is incorrect. Xmn is the size of the heap for the young generation.
> If somebody new to Java just reads the Ambari description and set both Xmn and Xmx to the same value, HBase will start but it will perform miserably. Please fix the documentation for the two settings in Ambari GUI that refer to Xmx (the ratio and the static value)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 307cb15
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 7ed92ed
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/configuration/hbase-env.xml 7218deb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml a1725e4
> ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/HBASE/configuration/hbase-env.xml 2e92f56
> ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HBASE/configuration/global.xml aff79f2
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/configuration/global.xml cc4baf4
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/configuration/global.xml 3a54dcb
>
> Diff: https://reviews.apache.org/r/32816/diff/
>
>
> Testing
> -------
>
> manual check
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 32816: Ambari UI for HBase config incorrectly
describes the -Xmn config
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32816/
-----------------------------------------------------------
(Updated April 6, 2015, 10:27 a.m.)
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-10350
https://issues.apache.org/jira/browse/AMBARI-10350
Repository: ambari
Description
-------
Ambari GUI for HBase config incorrectly describes the -Xmn as the “maximum value for the minimum heap size”, which is incorrect. Xmn is the size of the heap for the young generation.
If somebody new to Java just reads the Ambari description and set both Xmn and Xmx to the same value, HBase will start but it will perform miserably. Please fix the documentation for the two settings in Ambari GUI that refer to Xmx (the ratio and the static value)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 307cb15
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 7ed92ed
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/configuration/hbase-env.xml 7218deb
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml a1725e4
ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/HBASE/configuration/hbase-env.xml 2e92f56
ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HBASE/configuration/global.xml aff79f2
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/configuration/global.xml cc4baf4
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/configuration/global.xml 3a54dcb
Diff: https://reviews.apache.org/r/32816/diff/
Testing
-------
manual check
Thanks,
Dmitro Lisnichenko
Re: Review Request 32816: Ambari UI for HBase config incorrectly
describes the -Xmn config
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32816/#review78786
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On April 3, 2015, 3:44 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32816/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 3:44 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-10350
> https://issues.apache.org/jira/browse/AMBARI-10350
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari GUI for HBase config incorrectly describes the -Xmn as the “maximum value for the minimum heap size”, which is incorrect. Xmn is the size of the heap for the young generation.
> If somebody new to Java just reads the Ambari description and set both Xmn and Xmx to the same value, HBase will start but it will perform miserably. Please fix the documentation for the two settings in Ambari GUI that refer to Xmx (the ratio and the static value)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 307cb15
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 7ed92ed
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/configuration/hbase-env.xml 7218deb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml a1725e4
> ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/HBASE/configuration/hbase-env.xml 2e92f56
> ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HBASE/configuration/global.xml aff79f2
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/configuration/global.xml cc4baf4
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/configuration/global.xml 3a54dcb
>
> Diff: https://reviews.apache.org/r/32816/diff/
>
>
> Testing
> -------
>
> manual check
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>