You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ahshahid (via GitHub)" <gi...@apache.org> on 2026/01/21 04:03:22 UTC

[PR] [WIP][SPARK-55110][SQL] Order of application of 3 rules changed to achieve idempotency faster [spark]

ahshahid opened a new pull request, #53879:
URL: https://github.com/apache/spark/pull/53879

   ### What changes were proposed in this pull request?
   The order of application of 3 rules is changed from 
          ```
    BooleanSimplification,
           SimplifyConditionals,
           PushFoldableIntoBranches,
           SimplifyBinaryComparison,
   ```
   to
   ```
   SimplifyConditionals,
           SimplifyBinaryComparison,
           BooleanSimplification,
           PushFoldableIntoBranches,
   ```
   
   ### Why are the changes needed?
   This would help achieve idempotency in plan optimization faster, in some cases for eg
   `($"a" > 1000 && $"c" =!= false)`
   can achieve idempotency in one pass to 
   `$"a" > 1000 && $"c"`
   with the modified order, as BooleanSimplification rule becomes more efficient due to preprocessing by SimplifyBinaryComparison
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Added bugtest
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [WIP][SPARK-55110][SQL] Order of application of 3 rules changed to achieve idempotency faster [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53879:
URL: https://github.com/apache/spark/pull/53879#issuecomment-3776033074

   ## JIRA Issue Information
   
   === Improvement SPARK-55110 ===
   Summary: Order of rules BooleanSimplification and SimplifyBinaryComparison is suboptimal in achieving idempotency
   Assignee: None
   Status: Open
   Affected: ["4.2.0","4.1.1"]
   
   ---
   *This comment was automatically generated by GitHub Actions*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-55110][SQL] Order of application of 3 rules changed to achieve idempotency faster [spark]

Posted by "ahshahid (via GitHub)" <gi...@apache.org>.
ahshahid closed pull request #53879: [SPARK-55110][SQL] Order of application of 3 rules changed to achieve idempotency faster
URL: https://github.com/apache/spark/pull/53879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org