You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 07:39:46 UTC

[GitHub] [arrow] westonpace opened a new pull request, #12979: MINOR: [C++] Missed reference to ARROW_ENGINE during the rename

westonpace opened a new pull request, #12979:
URL: https://github.com/apache/arrow/pull/12979

   I had not thought to check .travis.yml.  The errors appeared to be completely unrelated and I'm still not entirely sure why we receive them.  However, in the past, we were not building parquet on the s390x build.  With ARROW-16158 we accidentally enabled parquet on this build.  This change should disable `ARROW_SUBSTRAIT` (and transitively, `ARROW_PARQUET`) so that the behavior is the same as it was before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kszucs commented on pull request #12979: ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename

Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #12979:
URL: https://github.com/apache/arrow/pull/12979#issuecomment-1108211354

   No worries, thanks for noticing the problem!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] westonpace closed pull request #12979: ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename

Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #12979: ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename
URL: https://github.com/apache/arrow/pull/12979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #12979: ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12979:
URL: https://github.com/apache/arrow/pull/12979#issuecomment-1113865690

   Benchmark runs are scheduled for baseline = 4a2668346cf55e01fb97add2bd561392c9e55068 and contender = dcde920f24673e917b2893129a0bf3304c470047. dcde920f24673e917b2893129a0bf3304c470047 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2c34bec911094fa695410d05c2b40e11...3bfaa61889a64a4e8bbeb986466d755f/)
   [Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cba6bdd6193049198a6f7b2f62891332...3aeb8292abca4b4ea9042e16fd43caa8/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/157a1d01c5a14b44979e6ca740c708cd...9fd29e6bb3ea4418bf91e9d36cf0aca7/)
   [Finished :arrow_down:0.17% :arrow_up:0.08%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/963ae09946d540589a1881129cfb87cd...0272e1423c7e45679292caf1a0193de3/)
   Buildkite builds:
   [Finished] [`dcde920f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/620)
   [Failed] [`dcde920f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/608)
   [Finished] [`dcde920f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/609)
   [Finished] [`dcde920f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/620)
   [Finished] [`4a266834` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/619)
   [Failed] [`4a266834` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/607)
   [Failed] [`4a266834` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/608)
   [Finished] [`4a266834` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/619)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] westonpace commented on pull request #12979: MINOR: [C++] Missed reference to ARROW_ENGINE during the rename

Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #12979:
URL: https://github.com/apache/arrow/pull/12979#issuecomment-1108191842

   @kou @kszucs Sorry for the trouble, this should get Travis back on track.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #12979: ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12979:
URL: https://github.com/apache/arrow/pull/12979#issuecomment-1108209451

   https://issues.apache.org/jira/browse/ARROW-16305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org