You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/16 13:40:42 UTC
[GitHub] [beam] dpcollins-google commented on a change in pull request #17094: Catch MonitoringInfoMetricName null keys or values in the constructor
dpcollins-google commented on a change in pull request #17094:
URL: https://github.com/apache/beam/pull/17094#discussion_r828022189
##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -48,6 +48,8 @@ private MonitoringInfoMetricName(String urn, Map<String, String> labels) {
// and ensure all necessary labels are set for the specific URN.
this.urn = urn;
for (Entry<String, String> entry : labels.entrySet()) {
+ checkArgument(entry.getKey() != null, "MonitoringInfoMetricName keys must be non-null");
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org