You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by SuperJDC <gi...@git.apache.org> on 2015/12/08 10:27:18 UTC
[GitHub] incubator-hawq pull request: a missing '\' in line 11
GitHub user SuperJDC opened a pull request:
https://github.com/apache/incubator-hawq/pull/168
a missing '\' in line 11
add ' \' to the end of line 11
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SuperJDC/incubator-hawq patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 00e29ca5dfd233a3780fc9da57feba15d3aa0c87
Author: SuperJDC <11...@qq.com>
Date: 2015-12-08T09:26:54Z
a missing '\' in line 11
add ' \' to the end of line 11
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-224. Fix syntax error of make di...
Posted by SuperJDC <gi...@git.apache.org>.
GitHub user SuperJDC reopened a pull request:
https://github.com/apache/incubator-hawq/pull/168
HAWQ-224. Fix syntax error of make distprep. a missing '\' in line 11.
add ' \' to the end of line 11
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SuperJDC/incubator-hawq patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 00e29ca5dfd233a3780fc9da57feba15d3aa0c87
Author: SuperJDC <11...@qq.com>
Date: 2015-12-08T09:26:54Z
a missing '\' in line 11
add ' \' to the end of line 11
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-224. Fix syntax error of make di...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/168#issuecomment-173437185
Sorry, I mean the commit message title, it should include the JIRA number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-224. Fix syntax error of make di...
Posted by SuperJDC <gi...@git.apache.org>.
Github user SuperJDC closed the pull request at:
https://github.com/apache/incubator-hawq/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-224. Fix syntax error of make di...
Posted by SuperJDC <gi...@git.apache.org>.
Github user SuperJDC closed the pull request at:
https://github.com/apache/incubator-hawq/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: a missing '\' in line 11
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/168#issuecomment-163089682
This fix the syntax error but did not fix 'make distprep' option, we might enable distprep option in the future. So this fix is okay.
The only issue is the commit message, we should follow the format. Please update the commit message before we merge it in. Thanks.
For example:
"HAWQ-224. Fix syntax error of make distprep."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---