[GitHub] [trafficcontrol] rawlinp commented on issue #5391: TO/TP unable to create types where use_in_table = cachegroup

[GitBox <gi...@apache.org>]

rawlinp commented on issue #5391:
URL: https://github.com/apache/trafficcontrol/issues/5391#issuecomment-754078267


   Ideally, we'd have a way to distinguish whether a server is a forward proxy or a reverse proxy other than by checking its server type prefix (EDGE/MID). That has always been a brittle way of determining that, maybe even a lazy hack to avoid adding a new database column or something. It really seems like there are two types at hand -- server type and proxy type. Right now we are conflating server type with both of those distinct types. Maybe we need to add a proxy type column to the server table, options being `REV/FWD/NONE`?
   
   For cachegroup types, I'm not sure there is much code (other than topology validation and a little MSO stuff) that actually checks the type of a cachegroup. So if we fix topology validation somehow to not depend on cachegroup type names for determining whether or not a cachegroup can be a leaf node, etc., we should be able to create and use new cachegroup types in topologies.
   
   It kind of seems like we'd need a proxy type column on the cachegroup _and_ the server, so we could validate that forward proxy cachegroups aren't leaf nodes. However, maybe a cache can just depend on its cachegroup for the proxy type rather than having the type in both the cachegroup and the server, but that seems kind of weird too.
   
   Maybe the MID/EDGE prefix checking is so built in at this point that we should just continue depending on it, and fix topology validation to check for EDGE/MID/ORG prefixes in the cachegroup type instead of the full type names. Then we could allow creating and using cachegroup types with those prefixes in topologies with all the proper validation. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org