You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2023/08/15 20:50:17 UTC

[PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

rzo1 opened a new pull request, #3569:
URL: https://github.com/apache/storm/pull/3569

   ## What is the purpose of the change
   
   Zookeeper 3.9.0 pulls in logback. However, we are using slf4j + log4j2, so we can remove that dependency. 
   Note: Some of our tests already complained about multiple logger bindings.
   
   ## How was the change tested
   
   GH Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3569:
URL: https://github.com/apache/storm/pull/3569#issuecomment-1680575973

   At least we will run into issues if we have logback and log4j2 in the classpath and slf4j tries to resolve it's binding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad merged PR #3569:
URL: https://github.com/apache/storm/pull/3569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3569:
URL: https://github.com/apache/storm/pull/3569#issuecomment-1680562718

   I think they are still relying on slf4j or at least we can bridge (at least judging from the mailing list and the issue tracker some people switched to log4j2). If this doesn't work out well, we might need to adapt.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org