[GitHub] [airflow] hankehly commented on a diff in pull request #26003: Add RdsInstanceSensor to amazon provider package

[GitBox <gi...@apache.org>]

hankehly commented on code in PR #26003:
URL: https://github.com/apache/airflow/pull/26003#discussion_r956548215


##########
airflow/providers/amazon/aws/sensors/rds.py:
##########
@@ -38,10 +38,10 @@ def __init__(self, *args, aws_conn_id: str = "aws_conn_id", hook_params: Optiona
         hook_params = hook_params or {}
         self.hook = RdsHook(aws_conn_id=aws_conn_id, **hook_params)
         self.target_statuses: List[str] = []
+        self.check_status_field = "Status"

Review Comment:
   Current sensors rely on the same `botocore` response structure. The response to [`describe_db_instances`](https://botocore.amazonaws.com/v1/documentation/api/latest/reference/services/rds.html#RDS.Client.describe_db_instances) uses a different field name to describe the state of the requested resource. I chose to define the field name as an instance variable because..
   - no need to update other sensor classes
   - no need to modify method signatures
   - minimal code changes
   - no extra conditional statements
   - it makes sense to define "sensor specific metadata" on the sensor class/instance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org