You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/07 19:48:58 UTC
[GitHub] [superset] AAfghahi opened a new pull request, #19602: docs: Added gtag
AAfghahi opened a new pull request, #19602:
URL: https://github.com/apache/superset/pull/19602
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Our current google analytics tag for the docusaurus website isn't working. The docs suggested this may be the reason:
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-google-gtag
I did not delete google analytics, wanted to first see if this made a difference.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on pull request #19602: docs: Added gtag to docusaurus
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on PR #19602:
URL: https://github.com/apache/superset/pull/19602#issuecomment-1113687670
@eschutho added package.json. When I was originally working on this I didn't realize that yarn added to the package, reinstalled and pushed it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19602: docs: Added gtag to docusaurus
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #19602:
URL: https://github.com/apache/superset/pull/19602#discussion_r856526206
##########
docs/yarn.lock:
##########
@@ -389,6 +389,27 @@
json5 "^2.1.2"
semver "^6.3.0"
+"@babel/core@^7.17.8":
Review Comment:
where did you add it to yarn? I'm pretty sure yarn uses package.json as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi merged pull request #19602: docs: Added gtag to docusaurus
Posted by GitBox <gi...@apache.org>.
AAfghahi merged PR #19602:
URL: https://github.com/apache/superset/pull/19602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a diff in pull request #19602: docs: Added gtag to docusaurus
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on code in PR #19602:
URL: https://github.com/apache/superset/pull/19602#discussion_r846308896
##########
docs/yarn.lock:
##########
@@ -389,6 +389,27 @@
json5 "^2.1.2"
semver "^6.3.0"
+"@babel/core@^7.17.8":
Review Comment:
I added the gtag plugin to yarn. docusaurus uses yarn install instead of npm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19602: docs: Added gtag to docusaurus
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #19602:
URL: https://github.com/apache/superset/pull/19602#discussion_r846273892
##########
docs/yarn.lock:
##########
@@ -389,6 +389,27 @@
json5 "^2.1.2"
semver "^6.3.0"
+"@babel/core@^7.17.8":
Review Comment:
I don't see any changes to package.json. What caused this yarn.lock update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org