You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/05/28 19:34:33 UTC

Change in asterixdb[master]: [NO ISSUE] Dashboard tweaks

From Ian Maxon <im...@uci.edu>:

Ian Maxon has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683 )


Change subject: [NO ISSUE] Dashboard tweaks
......................................................................

[NO ISSUE] Dashboard tweaks

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Update lodash
- Add some modules to allowed CommonJS dependencies

Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
---
M asterixdb/asterix-dashboard/src/node/angular.json
M asterixdb/asterix-dashboard/src/node/package.json
M asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
3 files changed, 6 insertions(+), 3 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/83/11683/1

diff --git a/asterixdb/asterix-dashboard/src/node/angular.json b/asterixdb/asterix-dashboard/src/node/angular.json
index 839ff38..cbb4d83 100644
--- a/asterixdb/asterix-dashboard/src/node/angular.json
+++ b/asterixdb/asterix-dashboard/src/node/angular.json
@@ -33,6 +33,9 @@
               "hammerjs",
               "lodash",
               "file-saver",
+              "codemirror",
+              "webcola",
+              "dagre"
             ]
           },
           "configurations": {
diff --git a/asterixdb/asterix-dashboard/src/node/package.json b/asterixdb/asterix-dashboard/src/node/package.json
index da627b9..8aef8bd 100755
--- a/asterixdb/asterix-dashboard/src/node/package.json
+++ b/asterixdb/asterix-dashboard/src/node/package.json
@@ -34,7 +34,7 @@
     "core-js": "3.8.3",
     "file-saver": "2.0.5",
     "hammerjs": "2.0.8",
-    "lodash": "^4.17.20",
+    "lodash": "^4.17.21",
     "roboto-fontface": "^0.10.0",
     "rxjs": "6.6.3",
     "rxjs-compat": "6.6.3",
diff --git a/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json b/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
index 693c7a7..cf5bba0 100755
--- a/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
+++ b/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
@@ -21,6 +21,6 @@
     },
     "exclude": [
         "test.ts",
-        "**/*.spec.ts"
+        "**/*.spec.ts",
     ]
-}
\ No newline at end of file
+}

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-MessageType: newchange

Change in asterixdb[master]: [NO ISSUE] Dashboard tweaks

Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ian Maxon <im...@uci.edu>:

Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683 )

Change subject: [NO ISSUE] Dashboard tweaks
......................................................................


Patch Set 3: Contrib+2 Code-Review+2

forwarding review from rebase. doesnt make contrib tests any worse.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: milesh1@uci.edu
Gerrit-Comment-Date: Fri, 04 Jun 2021 16:12:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in asterixdb[master]: [NO ISSUE] Dashboard tweaks

Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ian Maxon <im...@uci.edu>:

Ian Maxon has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683 )


Change subject: [NO ISSUE] Dashboard tweaks
......................................................................

[NO ISSUE] Dashboard tweaks

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Update lodash
- Add some modules to allowed CommonJS dependencies

Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
---
M asterixdb/asterix-dashboard/src/node/angular.json
M asterixdb/asterix-dashboard/src/node/package.json
M asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
3 files changed, 6 insertions(+), 3 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/83/11683/1

diff --git a/asterixdb/asterix-dashboard/src/node/angular.json b/asterixdb/asterix-dashboard/src/node/angular.json
index 839ff38..cbb4d83 100644
--- a/asterixdb/asterix-dashboard/src/node/angular.json
+++ b/asterixdb/asterix-dashboard/src/node/angular.json
@@ -33,6 +33,9 @@
               "hammerjs",
               "lodash",
               "file-saver",
+              "codemirror",
+              "webcola",
+              "dagre"
             ]
           },
           "configurations": {
diff --git a/asterixdb/asterix-dashboard/src/node/package.json b/asterixdb/asterix-dashboard/src/node/package.json
index da627b9..8aef8bd 100755
--- a/asterixdb/asterix-dashboard/src/node/package.json
+++ b/asterixdb/asterix-dashboard/src/node/package.json
@@ -34,7 +34,7 @@
     "core-js": "3.8.3",
     "file-saver": "2.0.5",
     "hammerjs": "2.0.8",
-    "lodash": "^4.17.20",
+    "lodash": "^4.17.21",
     "roboto-fontface": "^0.10.0",
     "rxjs": "6.6.3",
     "rxjs-compat": "6.6.3",
diff --git a/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json b/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
index 693c7a7..cf5bba0 100755
--- a/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
+++ b/asterixdb/asterix-dashboard/src/node/src/tsconfig.app.json
@@ -21,6 +21,6 @@
     },
     "exclude": [
         "test.ts",
-        "**/*.spec.ts"
+        "**/*.spec.ts",
     ]
-}
\ No newline at end of file
+}

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-MessageType: newchange

Change in asterixdb[master]: [NO ISSUE] Dashboard tweaks

Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683 )

Change subject: [NO ISSUE] Dashboard tweaks
......................................................................


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/C1HYAcnruNwCmbsE9 : UNSTABLE


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: milesh1@uci.edu
Gerrit-Comment-Date: Thu, 03 Jun 2021 19:23:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in asterixdb[master]: [NO ISSUE] Dashboard tweaks

Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:

Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683 )

Change subject: [NO ISSUE] Dashboard tweaks
......................................................................


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/12041/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11683
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaffc8c8f2f51e6fe5ce30b03db1bca43b92b248b
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: milesh1@uci.edu
Gerrit-Comment-Date: Thu, 03 Jun 2021 17:53:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment