You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2022/12/08 20:04:21 UTC
[superset] branch testing-tunnel updated (53a7df182c -> 4be69bb48c)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch testing-tunnel
in repository https://gitbox.apache.org/repos/asf/superset.git
from 53a7df182c remove some logs and using ad
new a88de4ade6 force commit
new 4be69bb48c add log for creating
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
superset/databases/commands/create.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[superset] 01/02: force commit
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch testing-tunnel
in repository https://gitbox.apache.org/repos/asf/superset.git
commit a88de4ade63d0887aec37db404e90c67334b828d
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Dec 8 14:12:29 2022 -0500
force commit
---
superset/databases/commands/create.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/superset/databases/commands/create.py b/superset/databases/commands/create.py
index aa5c4df766..caaad428a1 100644
--- a/superset/databases/commands/create.py
+++ b/superset/databases/commands/create.py
@@ -81,7 +81,7 @@ class CreateDatabaseCommand(BaseCommand):
**ssh_tunnel_properties,
"database_id": database.id,
},
- commit=False,
+ commit=True,
)
# adding a new database we always want to force refresh schema list
@@ -91,7 +91,6 @@ class CreateDatabaseCommand(BaseCommand):
"schema_access", security_manager.get_schema_perm(database, schema)
)
- db.session.add(ssh_tunnel)
db.session.commit()
except DAOCreateFailedError as ex:
db.session.rollback()
[superset] 02/02: add log for creating
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch testing-tunnel
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 4be69bb48cf62fb18e5a7975b439f2874b33b282
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Dec 8 15:03:55 2022 -0500
add log for creating
---
superset/databases/commands/create.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/superset/databases/commands/create.py b/superset/databases/commands/create.py
index caaad428a1..958c7ed213 100644
--- a/superset/databases/commands/create.py
+++ b/superset/databases/commands/create.py
@@ -76,6 +76,7 @@ class CreateDatabaseCommand(BaseCommand):
import json
if ssh_tunnel_properties := self._properties.get("ssh_tunnel"):
+ logger.info("[ssh] creating ssh tunnel")
ssh_tunnel = SSHTunnelDAO.create(
{
**ssh_tunnel_properties,