You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Wendy Smoak (JIRA)" <ji...@codehaus.org> on 2007/03/12 05:52:33 UTC
[jira] Created: (MPIR-63) Allow configuration of scm connection,
developerConnection and url
Allow configuration of scm connection, developerConnection and url
------------------------------------------------------------------
Key: MPIR-63
URL: http://jira.codehaus.org/browse/MPIR-63
Project: Maven 2.x Project Info Reports Plugin
Issue Type: New Feature
Affects Versions: 2.0.1
Reporter: Wendy Smoak
Priority: Minor
Fix For: 2.1
When the project site is kept in a separate module, the generated source-repository.html page has the wrong url.
For example, the source repository page in the top-level MyFaces site ( http://myfaces.apache.org/source-repository.html ) instructs the reader to check out the site instead of the project code:
$ svn checkout http://svn.apache.org/repos/asf/myfaces/site/trunk myfaces
Changing the <scm> urls to make the generated page correct is not a good solution since CI servers such as Continuum use that information to check out and build the project.
The Project Info Reports plugin should allow the scm connection, developerConnection and url to be overridden in plugin configuration.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPIR-63) Allow configuration of scm connection,
developerConnection and url
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPIR-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_89728 ]
Wendy Smoak commented on MPIR-63:
---------------------------------
On irc, Jason pointed out that I should use expression and default-value, so
/**
* The scm developer connection url
*
* @parameter expression="${mpir.developerConnection}" default-value="${project.scm.developerConnection}"
*/
private String developerConnection;
With that change, I'm seeing different behavior depending on whether I name the variable as above, or
private String devConnection;
When the variable is named developerConnection, anything I put in <plugin><configuration><developerConnection> "wins". (That seems to be why my original patch is working, it takes pom configuration if present, else it falls back to the scm developer connection.) Adding -Dmpir.developerConnection=... on the command line will *not* override the pom configuration, though it does work in the absence of pom configuration.
When the variable is named devConnection, then neither <plugin><configuration><developerConnection> nor <plugin><configuration><mpir.developerConnection> works in pom.xml. *Only* -Dmpir.developerConnection=... on the command line works.
Since this one is likely to be configured in the pom I'm leaning towards the first option. But I don't understand why I can't seem to get pom config that is overrideable on the command line to work.
> Allow configuration of scm connection, developerConnection and url
> ------------------------------------------------------------------
>
> Key: MPIR-63
> URL: http://jira.codehaus.org/browse/MPIR-63
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: New Feature
> Affects Versions: 2.0.1
> Reporter: Wendy Smoak
> Priority: Minor
> Fix For: 2.1
>
> Attachments: MPIR-63-developerConnection.patch
>
>
> When the project site is kept in a separate module, the generated source-repository.html page has the wrong url.
> For example, the source repository page in the top-level MyFaces site ( http://myfaces.apache.org/source-repository.html ) instructs the reader to check out the site instead of the project code:
> $ svn checkout http://svn.apache.org/repos/asf/myfaces/site/trunk myfaces
> Changing the <scm> urls to make the generated page correct is not a good solution since CI servers such as Continuum use that information to check out and build the project.
> The Project Info Reports plugin should allow the scm connection, developerConnection and url to be overridden in plugin configuration.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPIR-63) Allow configuration of scm connection,
developerConnection and url
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPIR-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak updated MPIR-63:
----------------------------
Attachment: MPIR-63-developerConnection.patch
The attached patch makes only developerConnection configurable. I'd like someone to look at it before I go on with the other two parameters.
> Allow configuration of scm connection, developerConnection and url
> ------------------------------------------------------------------
>
> Key: MPIR-63
> URL: http://jira.codehaus.org/browse/MPIR-63
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: New Feature
> Affects Versions: 2.0.1
> Reporter: Wendy Smoak
> Priority: Minor
> Fix For: 2.1
>
> Attachments: MPIR-63-developerConnection.patch
>
>
> When the project site is kept in a separate module, the generated source-repository.html page has the wrong url.
> For example, the source repository page in the top-level MyFaces site ( http://myfaces.apache.org/source-repository.html ) instructs the reader to check out the site instead of the project code:
> $ svn checkout http://svn.apache.org/repos/asf/myfaces/site/trunk myfaces
> Changing the <scm> urls to make the generated page correct is not a good solution since CI servers such as Continuum use that information to check out and build the project.
> The Project Info Reports plugin should allow the scm connection, developerConnection and url to be overridden in plugin configuration.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPIR-63) Allow configuration of scm connection,
developerConnection and url
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPIR-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_89777 ]
Wendy Smoak commented on MPIR-63:
---------------------------------
[00:12] <wsmoak> I expected there to be a connection between expression="${something} and <plugin><configuration><something>
[00:16] <wsmoak> instead, I see one link between expression="${something}" and -Dsomething=xyz
[00:17] <wsmoak> and an entirely different link between <plugin><configuration><something> and the variable name in private String something;
[00:18] <brett> wsmoak: that's correct
[00:18] <brett> expression is poorly named, it should be removed
[00:18] <brett> expression="${foo}" is more like property="foo"
[00:18] <brett> or something along those lines
[00:18] <brett> configuration maps directly to the field name
[00:19] <brett> and it defaults to the expression in default-value
So even though @parameter expression="${project.scm.developerConnection}" works, I should use @parameter default-value="${project.scm.developerConnection}" instead.
Meanwhile, the docs say that default-value is just a string, and that you're supposed to use expression to refer to specific elements in the pom.
>From http://maven.apache.org/developers/mojo-api-specification.html :
@parameter expression="${someExpression}" default-value="value"
Specifies the expression used to calculate the value to be injected into this parameter of the Mojo at buildtime. This is commonly used to refer to specific elements in the POM, such as ${project.build.resources}, which refers to the List of resources meant to accompany the classes in the resulting jar file. The default value is used when the expression evaluates to null
> Allow configuration of scm connection, developerConnection and url
> ------------------------------------------------------------------
>
> Key: MPIR-63
> URL: http://jira.codehaus.org/browse/MPIR-63
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: New Feature
> Affects Versions: 2.0.1
> Reporter: Wendy Smoak
> Priority: Minor
> Fix For: 2.1
>
> Attachments: MPIR-63-developerConnection.patch
>
>
> When the project site is kept in a separate module, the generated source-repository.html page has the wrong url.
> For example, the source repository page in the top-level MyFaces site ( http://myfaces.apache.org/source-repository.html ) instructs the reader to check out the site instead of the project code:
> $ svn checkout http://svn.apache.org/repos/asf/myfaces/site/trunk myfaces
> Changing the <scm> urls to make the generated page correct is not a good solution since CI servers such as Continuum use that information to check out and build the project.
> The Project Info Reports plugin should allow the scm connection, developerConnection and url to be overridden in plugin configuration.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MPIR-63) Allow configuration of scm connection,
developerConnection and url
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPIR-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak closed MPIR-63.
---------------------------
Resolution: Fixed
Fixed in r520740
> Allow configuration of scm connection, developerConnection and url
> ------------------------------------------------------------------
>
> Key: MPIR-63
> URL: http://jira.codehaus.org/browse/MPIR-63
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: New Feature
> Affects Versions: 2.0.1
> Reporter: Wendy Smoak
> Assigned To: Wendy Smoak
> Priority: Minor
> Fix For: 2.1
>
> Attachments: MPIR-63-developerConnection.patch, MPIR-63-wsmoak.patch
>
>
> When the project site is kept in a separate module, the generated source-repository.html page has the wrong url.
> For example, the source repository page in the top-level MyFaces site ( http://myfaces.apache.org/source-repository.html ) instructs the reader to check out the site instead of the project code:
> $ svn checkout http://svn.apache.org/repos/asf/myfaces/site/trunk myfaces
> Changing the <scm> urls to make the generated page correct is not a good solution since CI servers such as Continuum use that information to check out and build the project.
> The Project Info Reports plugin should allow the scm connection, developerConnection and url to be overridden in plugin configuration.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPIR-63) Allow configuration of scm connection,
developerConnection and url
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPIR-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak updated MPIR-63:
----------------------------
Attachment: MPIR-63-wsmoak.patch
This adds developerConnection, anonymousConnection and webAccessUrl properties, and an example.
It works. :) Suggestions welcome... I'll commit it in a couple of days pending comments.
> Allow configuration of scm connection, developerConnection and url
> ------------------------------------------------------------------
>
> Key: MPIR-63
> URL: http://jira.codehaus.org/browse/MPIR-63
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: New Feature
> Affects Versions: 2.0.1
> Reporter: Wendy Smoak
> Assigned To: Wendy Smoak
> Priority: Minor
> Fix For: 2.1
>
> Attachments: MPIR-63-developerConnection.patch, MPIR-63-wsmoak.patch
>
>
> When the project site is kept in a separate module, the generated source-repository.html page has the wrong url.
> For example, the source repository page in the top-level MyFaces site ( http://myfaces.apache.org/source-repository.html ) instructs the reader to check out the site instead of the project code:
> $ svn checkout http://svn.apache.org/repos/asf/myfaces/site/trunk myfaces
> Changing the <scm> urls to make the generated page correct is not a good solution since CI servers such as Continuum use that information to check out and build the project.
> The Project Info Reports plugin should allow the scm connection, developerConnection and url to be overridden in plugin configuration.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira