You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2012/06/29 15:43:44 UTC
[jira] [Created] (OAK-161) Refactor Tree#getChildStatus
angela created OAK-161:
--------------------------
Summary: Refactor Tree#getChildStatus
Key: OAK-161
URL: https://issues.apache.org/jira/browse/OAK-161
Project: Jackrabbit Oak
Issue Type: Improvement
Components: core
Reporter: angela
as discussed today Tree#getChildStatus is a bit problematic from my point
of view as it requires the parent Tree to be always accessible. as discussed
and stated multiple times in the past that may not be always the case.
a part from the drawback it offers once we have access control in place
it doesn't work for the root node, which doesn't have a parent by definition.
therefore i would suggest to refactor the method to Tree#getStatus and make it
an implementation detail if the status is stored with the parent or the tree
itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-161) Refactor Tree#getChildStatus
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved OAK-161.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.4
Fixed at revision 1357314
> Refactor Tree#getChildStatus
> ----------------------------
>
> Key: OAK-161
> URL: https://issues.apache.org/jira/browse/OAK-161
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: angela
> Assignee: Michael Dürig
> Fix For: 0.4
>
>
> as discussed today Tree#getChildStatus is a bit problematic from my point
> of view as it requires the parent Tree to be always accessible. as discussed
> and stated multiple times in the past that may not be always the case.
> a part from the drawback it offers once we have access control in place
> it doesn't work for the root node, which doesn't have a parent by definition.
> therefore i would suggest to refactor the method to Tree#getStatus and make it
> an implementation detail if the status is stored with the parent or the tree
> itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OAK-161) Refactor Tree#getChildStatus
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig reassigned OAK-161:
---------------------------------
Assignee: Michael Dürig
> Refactor Tree#getChildStatus
> ----------------------------
>
> Key: OAK-161
> URL: https://issues.apache.org/jira/browse/OAK-161
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: angela
> Assignee: Michael Dürig
>
> as discussed today Tree#getChildStatus is a bit problematic from my point
> of view as it requires the parent Tree to be always accessible. as discussed
> and stated multiple times in the past that may not be always the case.
> a part from the drawback it offers once we have access control in place
> it doesn't work for the root node, which doesn't have a parent by definition.
> therefore i would suggest to refactor the method to Tree#getStatus and make it
> an implementation detail if the status is stored with the parent or the tree
> itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira