You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/19 18:20:21 UTC

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

sandeepvinayak commented on a change in pull request #3283:
URL: https://github.com/apache/hbase/pull/3283#discussion_r635481243



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -165,6 +165,12 @@ public void run() {
         } catch (InterruptedException e) {
           LOG.trace("Interrupted while sleeping between WAL reads");
           Thread.currentThread().interrupt();
+        } catch (WALEntryFilterRetryableException e) {

Review comment:
       @shahrs87 That will make the `filter` method in `WALEntryFilter` to throw checked exception and it is not good to do that because of a breaking change with `throws` in the method signature. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org