You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/24 11:10:18 UTC
[GitHub] [fineract] Grandolf49 opened a new pull request #1272: FINERACT-1105 Swagger generates valid Spec File
Grandolf49 opened a new pull request #1272:
URL: https://github.com/apache/fineract/pull/1272
## Description
This is a backport PR of #1270 for adding the changes in Fineract `1.4.0` version
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [x] Integration tests have been created/updated for verifying the changes made.
- [x] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger edited a comment on pull request #1272: FINERACT-1105 Swagger generates valid Spec File
Posted by GitBox <gi...@apache.org>.
vorburger edited a comment on pull request #1272:
URL: https://github.com/apache/fineract/pull/1272#issuecomment-680304508
> @vorburger Could you let me know which steps you executed to merge this PR into 1.4.0?
Nothing special, but note how at the very top of this PR, or likewise e.g. on #1278 it says (said) _wants to merge 1 commit into apache:1.4.0_ ? Basically on GitHub when you (anyone) raises a PR, there's a drop-down at the top to choose what branch you are proposing a change for. So for this PR @Grandolf49 (not me) suggested a change for `1.4.0` instead of `develop` to the project, and I'm doing the same in #1273.
To merge it, after you gave your OK in the previous comment, I then just clicked the Rebase and Merge button! :smiley:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1272: FINERACT-1105 Swagger generates valid Spec File
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1272:
URL: https://github.com/apache/fineract/pull/1272#issuecomment-680144095
@vorburger fine with me... I'll pick this up for 1.4.0
On Tue, Aug 25, 2020 at 5:32 PM Michael Vorburger ⛑️ <
notifications@github.com> wrote:
> *@vorburger* approved this pull request.
>
> Backporting this to 1.4.0 is fine with me, but I'd prefer the Release
> Manager (RM) @vidakovic <https://github.com/vidakovic> to LGTM and merge
> this, it should be his discretion.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1272#pullrequestreview-474601635>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAC4ZLZWVKIKDFNO2LJBWTTSCPKQ7ANCNFSM4QJMETOQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1272: FINERACT-1105 Swagger generates valid Spec File
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1272:
URL: https://github.com/apache/fineract/pull/1272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1272: FINERACT-1105 Swagger generates valid Spec File
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1272:
URL: https://github.com/apache/fineract/pull/1272#issuecomment-680300584
@vorburger Could you let me know which steps you executed to merge this PR into 1.4.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1272: FINERACT-1105 Swagger generates valid Spec File
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1272:
URL: https://github.com/apache/fineract/pull/1272#issuecomment-680304508
> @vorburger Could you let me know which steps you executed to merge this PR into 1.4.0?
Nothing special, but note how at the very top of this PR, or likewise e.g. on #1278 it says (said) _wants to merge 1 commit into apache:1.4.0_ ? Basically on GitHub when you (anyone) raises a PR, there's a drop-down at the top to choose what branch you are proposing a change for. So for this PR @Grandolf49 (not me) suggested a change for 1.4.0 instead of develop to the project, and I'm doing the same in #1273.
To merge it, after you gave your OK in the previous comment, I then just clicked the Rebase and Merge button! :smiley:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org