You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by mheemskerk <gi...@git.apache.org> on 2017/09/27 14:03:06 UTC

[GitHub] httpcomponents-core pull request #52: HTTPCORE-491 make basicasyncresponseco...

GitHub user mheemskerk opened a pull request:

    https://github.com/apache/httpcomponents-core/pull/52

    HTTPCORE-491 make basicasyncresponseconsumer paranoid

    `BasicAsyncRequestConsumer` and `BasicAsyncResponseConsumer` used to
    blindly pre-allocate a buffer of `Content-Length`. If the request / response
    is crafted to have a very large `Content-Length` header, this can result in
    `OutOfMemoryError`s.
    
    This limits the initial buffer size to 256kb, while still allowing the
    buffer to grow if a larger message is read.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mheemskerk/httpcomponents-core HTTPCORE-491-make-basicasyncresponseconsumer-paranoid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcomponents-core/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----
commit 273c1817ebd4ab40e29c05365e488cdd76a4186b
Author: Michael Heemskerk <mh...@atlassian.com>
Date:   2017-09-27T14:00:30Z

    HTTPCORE-491 Make BasicAsyncRequest|ResponseConsumer more paranoid
    
    BasicAsyncRequestConsumer and BasicAsyncResponseConsumer used to
    blindly pre-allocate a buffer of Content-Length. If the request / response
    is crafted to have a very large Content-Length header, this can result in
    OutOfMemoryErrors.
    
    This limits the initial buffer size to 256kb, while still allowing the
    buffer to grow if a larger message is read.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-core issue #52: HTTPCORE-491 make basicasyncresponseconsumer ...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-core/pull/52
  
    Committed to 4.4.x branch. Please review and close.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-core pull request #52: HTTPCORE-491 make basicasyncresponseco...

Posted by mheemskerk <gi...@git.apache.org>.
Github user mheemskerk closed the pull request at:

    https://github.com/apache/httpcomponents-core/pull/52


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org