You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by huerlisi <gi...@git.apache.org> on 2015/03/30 12:46:46 UTC
[GitHub] thrift pull request: Fixes nodejs readme syntax
GitHub user huerlisi opened a pull request:
https://github.com/apache/thrift/pull/411
Fixes nodejs readme syntax
The README for nodejs examples had strange syntax letting Markdown thinking everything is a header.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huerlisi/thrift fixes/nodejs-readme-syntax
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #411
----
commit 3659cc77e3e7446f91b92031c5d60aeaf0438759
Author: Simon Hürlimann (CyT) <si...@cyt.ch>
Date: 2015-03-30T10:37:48Z
nodejs: Fix Markdown syntax for README.
commit b57d312fcd360b03eb6d2bc5fb8318c6eab05150
Author: Simon Hürlimann (CyT) <si...@cyt.ch>
Date: 2015-03-30T10:45:03Z
nodejs: Add main header to example README.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-90731296
Thanks Simon!
just committed this, please check this for the next PR
https://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by huerlisi <gi...@git.apache.org>.
Github user huerlisi closed the pull request at:
https://github.com/apache/thrift/pull/411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by huerlisi <gi...@git.apache.org>.
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-87632748
Sorry, accidentally checked in a generated file, will fix and amend the last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by huerlisi <gi...@git.apache.org>.
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-87633148
Fixed, ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by huerlisi <gi...@git.apache.org>.
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-87639738
The failing test (Haskel: https://travis-ci.org/apache/thrift/jobs/56395742) seems to be unrelated to my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by huerlisi <gi...@git.apache.org>.
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-93250554
Thanks for the heads up:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fixes nodejs readme syntax
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-93084562
Given this was committed, you can close the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---