You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2022/02/08 09:36:46 UTC

[GitHub] [jmeter] SampathKumarAmex opened a new pull request #697: Used JUnit 5 assertion API to keep it consistent with JUnit 5 tests

SampathKumarAmex opened a new pull request #697:
URL: https://github.com/apache/jmeter/pull/697


   ## Description
   Used JUnit 5 assertion API in the test to keep it consistent with JUnit 5 `@Test` annotation
   
   ## Motivation and Context
   Keeping test annotation and assertion API usage consistent in the unit test
   
   ## How Has This Been Tested?
   n/a - Build file change
   
   ## Screenshots (if appropriate):
   n/a
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [X] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] asfgit closed pull request #697: Used JUnit 5 assertion API to keep it consistent with JUnit 5 tests

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #697:
URL: https://github.com/apache/jmeter/pull/697


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] vlsi commented on pull request #697: Used JUnit 5 assertion API to keep it consistent with JUnit 5 tests

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #697:
URL: https://github.com/apache/jmeter/pull/697#issuecomment-1032406370


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org