You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "quantranhong1999 (via GitHub)" <gi...@apache.org> on 2023/07/17 10:03:44 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request, #1646: JAMES-3755 Healthcheck for Rspamd
quantranhong1999 opened a new pull request, #1646:
URL: https://github.com/apache/james-project/pull/1646
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1646: JAMES-3755 Healthcheck for Rspamd
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #1646:
URL: https://github.com/apache/james-project/pull/1646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1646: JAMES-3755 Healthcheck for Rspamd
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1646:
URL: https://github.com/apache/james-project/pull/1646#discussion_r1265272339
##########
third-party/rspamd/src/test/java/org/apache/james/rspamd/DockerClamAV.java:
##########
@@ -41,7 +42,8 @@ public DockerClamAV(Network network) {
.withNetwork(network)
.withCreateContainerCmdModifier(createContainerCmd -> createContainerCmd.withName("james-clamav-test-" + UUID.randomUUID()))
.withNetworkAliases("clamav")
- .waitingFor(Wait.forHealthcheck());
+ .waitingFor(Wait.forHealthcheck()
+ .withStartupTimeout(Duration.ofMinutes(2)));
Review Comment:
what do you think if we have a file configured somewhere, or read it from env?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1646: JAMES-3755 Healthcheck for Rspamd
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1646:
URL: https://github.com/apache/james-project/pull/1646#discussion_r1265277032
##########
third-party/rspamd/src/test/java/org/apache/james/rspamd/DockerClamAV.java:
##########
@@ -41,7 +42,8 @@ public DockerClamAV(Network network) {
.withNetwork(network)
.withCreateContainerCmdModifier(createContainerCmd -> createContainerCmd.withName("james-clamav-test-" + UUID.randomUUID()))
.withNetworkAliases("clamav")
- .waitingFor(Wait.forHealthcheck());
+ .waitingFor(Wait.forHealthcheck()
+ .withStartupTimeout(Duration.ofMinutes(2)));
Review Comment:
of course, it is not for only ClamAV
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1646: JAMES-3755 Healthcheck for Rspamd
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #1646:
URL: https://github.com/apache/james-project/pull/1646#discussion_r1266105613
##########
third-party/rspamd/src/test/java/org/apache/james/rspamd/DockerClamAV.java:
##########
@@ -41,7 +42,8 @@ public DockerClamAV(Network network) {
.withNetwork(network)
.withCreateContainerCmdModifier(createContainerCmd -> createContainerCmd.withName("james-clamav-test-" + UUID.randomUUID()))
.withNetworkAliases("clamav")
- .waitingFor(Wait.forHealthcheck());
+ .waitingFor(Wait.forHealthcheck()
+ .withStartupTimeout(Duration.ofMinutes(2)));
Review Comment:
I think a timeout env variable may help for different (slow/fast) environments.
But as long as we hardcode that timeout high enough, it is still fine for whatsoever environment. (fast env still finishes starting container regardless of the timeout)
Let's keep that in mind and let that out of this PR scope IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1646: JAMES-3755 Healthcheck for Rspamd
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1646:
URL: https://github.com/apache/james-project/pull/1646#discussion_r1265465271
##########
third-party/rspamd/src/main/java/org/apache/james/rspamd/client/RspamdHttpClient.java:
##########
@@ -104,9 +104,10 @@ public final int hashCode() {
public static final String CHECK_V2_ENDPOINT = "/checkV2";
public static final String LEARN_SPAM_ENDPOINT = "/learnspam";
public static final String LEARN_HAM_ENDPOINT = "/learnham";
+ public static final String PING_ENDPOINT = "/ping";
private static final int OK = 200;
private static final int NO_CONTENT = 204;
- private static final int FORBIDDEN = 403;
+ private static final int UNAUTHORIZED = 401;
Review Comment:
I guess Quan doesn't want to import one more maven dependency for that
##########
third-party/rspamd/src/main/java/org/apache/james/rspamd/client/RspamdHttpClient.java:
##########
@@ -104,9 +104,10 @@ public final int hashCode() {
public static final String CHECK_V2_ENDPOINT = "/checkV2";
public static final String LEARN_SPAM_ENDPOINT = "/learnspam";
public static final String LEARN_HAM_ENDPOINT = "/learnham";
+ public static final String PING_ENDPOINT = "/ping";
private static final int OK = 200;
private static final int NO_CONTENT = 204;
- private static final int FORBIDDEN = 403;
+ private static final int UNAUTHORIZED = 401;
Review Comment:
I guess Quan doesn't want to import one more maven dependency for that
##########
third-party/rspamd/src/main/java/org/apache/james/rspamd/client/RspamdHttpClient.java:
##########
@@ -104,9 +104,10 @@ public final int hashCode() {
public static final String CHECK_V2_ENDPOINT = "/checkV2";
public static final String LEARN_SPAM_ENDPOINT = "/learnspam";
public static final String LEARN_HAM_ENDPOINT = "/learnham";
+ public static final String PING_ENDPOINT = "/ping";
private static final int OK = 200;
private static final int NO_CONTENT = 204;
- private static final int FORBIDDEN = 403;
+ private static final int UNAUTHORIZED = 401;
Review Comment:
I guess Quan doesn't want to import one more maven dependency for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1646: JAMES-3755 Healthcheck for Rspamd
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1646:
URL: https://github.com/apache/james-project/pull/1646#discussion_r1265461481
##########
third-party/rspamd/src/main/java/org/apache/james/rspamd/client/RspamdHttpClient.java:
##########
@@ -104,9 +104,10 @@ public final int hashCode() {
public static final String CHECK_V2_ENDPOINT = "/checkV2";
public static final String LEARN_SPAM_ENDPOINT = "/learnspam";
public static final String LEARN_HAM_ENDPOINT = "/learnham";
+ public static final String PING_ENDPOINT = "/ping";
private static final int OK = 200;
private static final int NO_CONTENT = 204;
- private static final int FORBIDDEN = 403;
+ private static final int UNAUTHORIZED = 401;
Review Comment:
We can't reuse an existing HTTP constant for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org