You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 15:34:54 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #19683: In DAG dependency detector, use class type instead of class name, related #19582

kaxil commented on a change in pull request #19683:
URL: https://github.com/apache/airflow/pull/19683#discussion_r752362440



##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -444,14 +446,14 @@ class DependencyDetector:
     @staticmethod
     def detect_task_dependencies(task: BaseOperator) -> Optional['DagDependency']:
         """Detects dependencies caused by tasks"""
-        if task.task_type == "TriggerDagRunOperator":
+        if isinstance(task, TriggerDagRunOperator):

Review comment:
       Since this is done during serialization time this should be ok, however can you please add test(s)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org