[GitHub] [beam] iindyk commented on a change in pull request #13175: Adding performance improvements to ApproximateQuantiles.

[GitBox <gi...@apache.org>]

iindyk commented on a change in pull request #13175:
URL: https://github.com/apache/beam/pull/13175#discussion_r521434129



##########
File path: sdks/python/apache_beam/transforms/stats.py
##########
@@ -299,15 +300,17 @@ class ApproximateQuantiles(object):
     out: [0, 2, 5, 7, 100]
   """
   @staticmethod
-  def _display_data(num_quantiles, key, reverse, weighted):
+  def _display_data(num_quantiles, key, reverse, weighted, batch_input):
     return {
         'num_quantiles': DisplayDataItem(num_quantiles, label='Quantile Count'),
         'key': DisplayDataItem(
             key.__name__
             if hasattr(key, '__name__') else key.__class__.__name__,
             label='Record Comparer Key'),
         'reverse': DisplayDataItem(str(reverse), label='Is Reversed'),
-        'weighted': DisplayDataItem(str(weighted), label='Is Weighted')
+        'weighted': DisplayDataItem(str(weighted), label='Is Weighted'),
+        'batch_input': DisplayDataItem(
+            str(batch_input), label='Is Input Batched')

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org