You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "Ostrzyciel (via GitHub)" <gi...@apache.org> on 2026/09/09 11:49:20 UTC
[PR] Correct ontology schema's $id field [ossie]
Ostrzyciel opened a new pull request, #372:
URL: https://github.com/apache/ossie/pull/372
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Summary
Change the `$id` of the ontology schema from `https://github.com/apache/ossie/core-spec/ossie-schema.json` to `https://github.com/apache/ossie/core-spec/ontology.json`.
ossie-schema.json is already taken by the main schema, which is also referenced in the ontology schema (`properties.ai_context.$ref`). This reference resolves incorrectly to the ontology schema (this JSON file), breaking validators. The `semantic_model` ref is broken in the same way.
## Related Issues
N/A
## Checklist
### Ontology
- [x] Ontology changes in `ontology/` are consistent with spec changes
- [x] New or modified terms are defined and documented
### Tests
- [x] All existing tests pass (`pytest` / CI green)
### Compliance
- [x] ASF license headers are present on all new source files
- [x] No third-party dependencies are added without PMC/IPMC approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct ontology schema's $id field [ossie]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #372:
URL: https://github.com/apache/ossie/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct ontology schema's $id field [ossie]
Posted by "Ostrzyciel (via GitHub)" <gi...@apache.org>.
Ostrzyciel commented on code in PR #372:
URL: https://github.com/apache/ossie/pull/372#discussion_r3970992716
##########
ontology/ontology.json:
##########
@@ -1,6 +1,6 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
- "$id": "https://github.com/apache/ossie/core-spec/ossie-schema.json",
+ "$id": "https://github.com/apache/ossie/core-spec/ontology.json",
Review Comment:
Ah, fair point, thanks. Fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct ontology schema's $id field [ossie]
Posted by "Ostrzyciel (via GitHub)" <gi...@apache.org>.
Ostrzyciel commented on code in PR #372:
URL: https://github.com/apache/ossie/pull/372#discussion_r3969202294
##########
ontology/ontology.json:
##########
@@ -1,6 +1,6 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
- "$id": "https://github.com/apache/ossie/core-spec/ossie-schema.json",
+ "$id": "https://github.com/apache/ossie/core-spec/ontology.json",
Review Comment:
Can I get a review from a human?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct ontology schema's $id field [ossie]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #372:
URL: https://github.com/apache/ossie/pull/372#discussion_r3970805952
##########
ontology/ontology.json:
##########
@@ -1,6 +1,6 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
- "$id": "https://github.com/apache/ossie/core-spec/ossie-schema.json",
+ "$id": "https://github.com/apache/ossie/core-spec/ontology.json",
Review Comment:
Very good catch!
What you do actually fix a real `$id` collision with `core-spec/ossie-schema.json`, which was causing the `ai_context`/`semantic_model` `$ref`s below to be ambiguous for any tool that loads both schemas into one registry.
Just a minor comment (nit): the new `$id` uses `core-spec/ontology.json`, but this file actually lives at `ontology/ontology.json`. `ossie-schema.json` `$id` mirrors its real path (`core-spec/ossie-schema.json`), so for consistency this might read better as:
```
"$id": "https://github.com/apache/ossie/ontology/ontology.json",
```
To be fair, it's clearly not required since `$id` here is just an opaque identifier rather than a fetchable URL, but it would match the repo's existing convention 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct ontology schema's $id field [ossie]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #372:
URL: https://github.com/apache/ossie/pull/372#discussion_r3968114347
##########
ontology/ontology.json:
##########
@@ -1,6 +1,6 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
- "$id": "https://github.com/apache/ossie/core-spec/ossie-schema.json",
+ "$id": "https://github.com/apache/ossie/core-spec/ontology.json",
Review Comment:
The new `$id` URI doesn’t appear to match the file’s path in the repository (`ontology/ontology.json`). Some schema tooling uses `$id` as the canonical retrieval location; pointing it to the wrong path can break remote resolution/caching. Consider using a URI that corresponds to the actual published location (e.g., including `/ontology/ontology.json` if that’s where it is served) while still avoiding the `ossie-schema.json` collision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org